Date: Sun, 18 Aug 2013 00:34:30 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Peter Wemm <peter@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: svn commit: r254273 - in head: . include lib lib/libc/iconv lib/libiconv_compat lib/libkiconv share/mk sys/sys tools/build/mk Message-ID: <3887D7C7-D766-40DF-B154-D05768B86AA6@FreeBSD.org> In-Reply-To: <201308130715.r7D7F1nu076335@svn.freebsd.org> References: <201308130715.r7D7F1nu076335@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 13, 2013, at 09:15, Peter Wemm <peter@FreeBSD.org> wrote: > Author: peter > Date: Tue Aug 13 07:15:01 2013 > New Revision: 254273 > URL: http://svnweb.freebsd.org/changeset/base/254273 >=20 > Log: > The iconv in libc did two things - implement the standard APIs, the = GNU > extensions and also tried to be link time compatible with ports = libiconv. > This splits that functionality and enables the parts that shouldn't > interfere with the port by default. >=20 > WITH_ICONV (now on by default) - adds iconv.h, iconv_open(3) etc. > WITH_LIBICONV_COMPAT (off by default) adds the libiconv_open etc API, = linker > symbols and even a stub libiconv.so.3 that are good enough to be able > to 'pkg delete -f libiconv' on a running system and reasonably expect = it > to work. >=20 > I have tortured many machines over the last few days to try and = reduce > the possibilities of foot-shooting as much as I can. I've = successfully > recompiled to enable and disable the libiconv_compat modes, ports = that use > libiconv alongside system iconv etc. If you don't enable the > WITH_LIBICONV_COMPAT switch, they don't share symbol space. >=20 > This is an extension of behavior on other system. iconv(3) is a = standard > libc interface and libiconv port expects to be able to run alongside = it on > systems that have it. Unfortunately I expect this will break many ports, when the libiconv port is installed. A simple example is the following: #include <iconv.h> int main(void) { iconv_t ic =3D iconv_open("UTF-8", "ISO-8859-1"); iconv_close(ic); return 0; } If you compile this on a system after r254273 with -I/usr/local/include, and the libiconv port installed, it will result in: $ cc -I/usr/local/include iconv-test.c -o iconv-test /tmp/iconv-test-I1ltw1.o: In function `main': iconv-test.c:(.text+0x21): undefined reference to `libiconv_open' iconv-test.c:(.text+0x2f): undefined reference to `libiconv_close' cc: error: linker command failed with exit code 1 (use -v to see = invocation) This is because libiconv's iconv.h does: #define iconv_open libiconv_open ... #define iconv_close libiconv_close and so on for most of its functions. -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3887D7C7-D766-40DF-B154-D05768B86AA6>