From owner-freebsd-doc@freebsd.org Mon Sep 25 04:08:04 2017 Return-Path: Delivered-To: freebsd-doc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8450CE089BF for ; Mon, 25 Sep 2017 04:08:04 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6565F6CF00 for ; Mon, 25 Sep 2017 04:08:04 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 647FEE089BC; Mon, 25 Sep 2017 04:08:04 +0000 (UTC) Delivered-To: doc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6215EE089BB; Mon, 25 Sep 2017 04:08:04 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-wr0-x22f.google.com (mail-wr0-x22f.google.com [IPv6:2a00:1450:400c:c0c::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E70586CEFF; Mon, 25 Sep 2017 04:08:03 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-wr0-x22f.google.com with SMTP id u96so5497563wrb.6; Sun, 24 Sep 2017 21:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=XbKb4X6v5/Y8KTqECik4bZUX4jv5OqoPDjFMBpeVFew=; b=Slxgo7PFwtNl+eDaYbr/HU2ItRhT/O+4wrjjDNRBHKzI9Fow/9NDk9Lsh6BjSgYxU6 dwCFntO8UZQIOXyMbV5eDZqUBCdibL3HiLorWQ+kwGUfqek+aOm5H51JEUIrkD3ZXfDB 1HbLdEgKYrOTe/NqGceVJ4oBi0Ynv1KFPQ5jYFrlXa9wuY8LAn2SjQLPzHm0sIv+UL5Z dORfheDnD97Edl4BTfhnuXa1QMtZGKfQfMiw3tJF3cIfw/CeRNonCaeVF+zRkBE8dMIM YsG4XOVlYGbPQIYvSlS1s8JulpO0F4388hGb2J9nlMFepKWytM+O2Dk5pVNHJWB/Juw9 TwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=XbKb4X6v5/Y8KTqECik4bZUX4jv5OqoPDjFMBpeVFew=; b=QjMNdYTBDaTVbm8QN5yCsuDWLJPn8MXM/pkeoEsd8XN3Rgip7+pYMvvmulusaHVDVY aLc335pWq5YDrt0HRpzhq8HJpKxljbGZcVFPvW3GKsXg7PScT/xA8MfNOjeK1+G0tXVs t4O+tRi9PJTrAcnGn17tH3bPzlgJcNUaVncPPSzhI3gfJj7xMHgaQNlWARsTlshKg9KK sbWunZpBAMAXrUxF7ORbI0hZAKWc+BmTzYKDfTHvugrPsMYNR52lIQQjCGPH/iJsT17N fPa9m8pZWHpq8fCoNJk7YC/tocporAW2VaTtwfAuH311TllCTNc/TE+XbLL28fpzYUgH T13A== X-Gm-Message-State: AHPjjUgvH+le18fNgmdjDDuYMpD6d9jbBO4Ll6SQfcYxXlLGrXlQMJkU Zk/4IwEDCc59YwHjwl75cfRnLW+zig5EiDUZWCY= X-Google-Smtp-Source: AOwi7QBpe4qoRr1ZLTjPUiJ/tiKg89E2BpWpfbqDQPMnWMss2TIJ8CBRWOOQHYIXMWJZ8KI/npfDct6DA+afVfWhbRs= X-Received: by 10.46.67.29 with SMTP id q29mr2248341lja.85.1506312482199; Sun, 24 Sep 2017 21:08:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.81.65 with HTTP; Sun, 24 Sep 2017 21:08:01 -0700 (PDT) From: Russell Haley Date: Sun, 24 Sep 2017 21:08:01 -0700 Message-ID: Subject: Porters Handbook section 4.4 To: freebsd-ports@freebsd.org, doc@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 04:08:04 -0000 Hi, Section 4.3 of the porters handbook talks about making modifications to a private copy of a tarball and recording the steps. Section 4.4 talks about changing directories into the affected ports dir and running make makepatch to generate patch files. I am unsure how the makepatch target is supposed to find my private directory. Since I was confused, I created patches, added them to the port, ran make, then ran make makepatch and the system re-generated new "makepatch" patches. So, my question is thus: To me, section 4.4 seems vague about where changes should be made, which is compounded by the information in section 4.3. Can the makepatch target ask for and find a private directory, or should the handbook be clarified to state that the changes should be made to the 'work' folder? If the later is true, I assume there is some proper workflow to keep changes from being destroyed while testing? If there is a section in the handbook clarifying this, please just say so and I will go find it. Thanks! Russ