From owner-freebsd-bugs  Fri Mar  3  3:10:25 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id C82BA37C006
	for <freebsd-bugs@FreeBSD.org>; Fri,  3 Mar 2000 03:10:15 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id DAA33147;
	Fri, 3 Mar 2000 03:10:04 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2FC8C37BFBC
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  3 Mar 2000 03:03:51 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id DAA32613;
	Fri, 3 Mar 2000 03:03:50 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Message-Id: <200003031103.DAA32613@freefall.freebsd.org>
Date: Fri, 3 Mar 2000 03:03:50 -0800 (PST)
From: peter.edwards@ireland.com
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: misc/17143: [PATCH] make "tunefs -p" work for mounted filesytems
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         17143
>Category:       misc
>Synopsis:       [PATCH] make "tunefs -p" work for mounted filesytems
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar  3 03:10:03 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Peter Edwards
>Release:        -current
>Organization:
>Environment:
FreeBSD rocklobster 4.0-CURRENT FreeBSD 4.0-CURRENT #3:
Fri Jan 21 09:42:06 GMT 2000     
petere@rocklobster:/usr/src/sys/compile/PME2  i386

>Description:
tunefs -p won't work on a mounted filesystem.
Here's a patch that works for me

>How-To-Repeat:
# tunefs -p /usr
tunefs: cannot work on read-write mounted file system
#
>Fix:
There's a check at the moment to check that a filesystem is mounted
R/W. If it is, tunefs exits prematurely. We need to avoid bailing out
at this point, and instead open the raw device in readonly mode
(otherwise we won't be able to open the device file, 'cause its busy)

Patch for /usr/src/sbin/tunefs/tunefs.c included

(uuencoded to keep whitespace for my cut-and-paste-to-web-browser)

begin 644 tunefs.patch
M*BHJ('1U;F5F<RYC+F]R:6<)1G)I($UA<B`@,R`Q,#HS,3HQ."`R,#`P"BTM
M+2!T=6YE9G,N8PE&<FD@36%R("`S(#$P.C0U.C4R(#(P,#`**BHJ*BHJ*BHJ
M*BHJ*BHJ"BHJ*B`W-RPX-R`J*BHJ"B`@"B`@=F]I9"!B=W)I=&4H9&%D9')?
M="P@8VAA<B`J+"!I;G0I.PH@(&EN="!B<F5A9"AD861D<E]T+"!C:&%R("HL
M(&EN="D["B$@=F]I9"!G971S8BAS=')U8W0@9G,@*BP@8VAA<B`J*3L*("!V
M;VED('5S86=E(%]?4"@H=F]I9"DI.PH@('9O:60@<')I;G1F<R!?7U`H*'9O
M:60I*3L*("`*+2!I;G0*("!M86EN*&%R9V,L(&%R9W8I"B`@"6EN="!A<F=C
M.PH@(`EC:&%R("IA<F=V6UT["BTM+2`W-RPX-B`M+2TM"B`@"B`@=F]I9"!B
M=W)I=&4H9&%D9')?="P@8VAA<B`J+"!I;G0I.PH@(&EN="!B<F5A9"AD861D
M<E]T+"!C:&%R("HL(&EN="D["B$@=F]I9"!G971S8BAS=')U8W0@9G,@*BP@
M8VAA<B`J+"!I;G0I.PH@('9O:60@=7-A9V4@7U]0*"AV;VED*2D["B`@=F]I
M9"!P<FEN=&9S(%]?4"@H=F]I9"DI.PH@(`H@(&UA:6XH87)G8RP@87)G=BD*
M("`):6YT(&%R9V,["B`@"6-H87(@*F%R9W9;73L**BHJ*BHJ*BHJ*BHJ*BHJ
M"BHJ*B`X.2PY-2`J*BHJ"B`@"6-H87(@*F-P+"`J<W!E8VEA;"P@*FYA;64L
M("IA8W1I;VX["B`@"7-T<G5C="!S=&%T('-T.PH@(`EI;G0@:3L*(2`):6YT
M($%F;&%G(#T@,"P@86-T:79E(#T@,#L*("`)<W1R=6-T(&9S=&%B("IF<SL*
M("`)8VAA<B`J8VAG6S)=+"!D979I8V5;34%84$%42$Q%3ET["B`@"7-T<G5C
M="!U9G-?87)G<R!A<F=S.PHM+2T@.#@L.30@+2TM+0H@(`EC:&%R("IC<"P@
M*G-P96-I86PL("IN86UE+"`J86-T:6]N.PH@(`ES=')U8W0@<W1A="!S=#L*
M("`):6YT(&D["B$@"6EN="!!9FQA9R`](#`L(&%C=&EV92`](#`L(&]P96YM
M;V1E(#T@3U]21%=2.PH@(`ES=')U8W0@9G-T86(@*F9S.PH@(`EC:&%R("IC
M:&=;,ETL(&1E=FEC95M-05A0051(3$5.73L*("`)<W1R=6-T('5F<U]A<F=S
M(&%R9W,["BHJ*BHJ*BHJ*BHJ*BHJ*@HJ*BH@,3`T+#$Q,"`J*BHJ"B`@"0EI
M9B`H<W1A=&9S*'-P96-I86PL("9S=&9S*2`]/2`P("8F"B`@"0D@("`@<W1R
M8VUP*'-P96-I86PL('-T9G,N9E]M;G1O;FYA;64I(#T](#`I('L*("`)"2`@
M("`):68@*"AS=&9S+F9?9FQA9W,@)B!-3E1?4D1/3DQ9*2`]/2`P*2!["B$@
M"0D)"65R<G@H,2P@(F-A;FYO="!W;W)K(&]N(')E860M=W)I=&4@;6]U;G1E
M9"!F:6QE('-Y<W1E;2(I.PH@(`D)"7T*("`)"0EA8W1I=F4@/2`Q.PH@(`D)
M?0HM+2T@,3`S+#$P.2`M+2TM"B`@"0EI9B`H<W1A=&9S*'-P96-I86PL("9S
M=&9S*2`]/2`P("8F"B`@"0D@("`@<W1R8VUP*'-P96-I86PL('-T9G,N9E]M
M;G1O;FYA;64I(#T](#`I('L*("`)"2`@("`):68@*"AS=&9S+F9?9FQA9W,@
M)B!-3E1?4D1/3DQ9*2`]/2`P*2!["B$@"0D)"6]P96YM;V1E(#T@3U]21$].
M3%D["B`@"0D)?0H@(`D)"6%C=&EV92`](#$["B`@"0E]"BHJ*BHJ*BHJ*BHJ
M*BHJ*@HJ*BH@,3(T+#$S,B`J*BHJ"B`@"6EF("@H<W0N<W1?;6]D92`F(%-?
M249-5"D@(3T@4U])1D),2R`F)@H@(`D@("`@*'-T+G-T7VUO9&4@)B!37TE&
M350I("$](%-?249#2%(I"B`@"0EE<G)X*#$P+"`B)7,Z(&YO="!A(&)L;V-K
M(&]R(&-H87)A8W1E<B!D979I8V4B+"!S<&5C:6%L*3L*(2`)9V5T<V(H)G-B
M;&]C:RP@<W!E8VEA;"D["B`@"69O<B`H.R!A<F=C(#X@,"`F)B!A<F=V6S!=
M6S!=(#T]("<M)SL@87)G8RTM+"!A<F=V*RLI('L*(2`)"69O<B`H8W`@/2`F
M87)G=ELP75LQ73L@*F-P.R!C<"LK*0H@(`D)"7-W:71C:"`H*F-P*2!["B`@
M"B`@"0D)8V%S92`G02<Z"BTM+2`Q,C,L,3,X("TM+2T*("`):68@*"AS="YS
M=%]M;V1E("8@4U])1DU4*2`A/2!37TE&0DQ+("8F"B`@"2`@("`H<W0N<W1?
M;6]D92`F(%-?249-5"D@(3T@4U])1D-(4BD*("`)"65R<G@H,3`L("(E<SH@
M;F]T(&$@8FQO8VL@;W(@8VAA<F%C=&5R(&1E=FEC92(L('-P96-I86PI.PHA
M(`EG971S8B@F<V)L;V-K+"!S<&5C:6%L+"!O<&5N;6]D92D["B`@"69O<B`H
M.R!A<F=C(#X@,"`F)B!A<F=V6S!=6S!=(#T]("<M)SL@87)G8RTM+"!A<F=V
M*RLI('L*(2`)"69O<B`H8W`@/2`F87)G=ELP75LQ73L@*F-P.R!C<"LK*2![
M"B$@"0D)+RH*(2`)"0D@*B!-86ME('-U<F4@=V4@9&]N)W0@871T96UP="!T
M;R!C:&%N9V4@86YY=&AI;F<@:68*(2`)"0D@*B!T:&4@9FEL92!S>7-T96T@
M:7,@;6]U;G1E9"!2+U<*(2`)"0D@*B\*(2`)"0EI9B`H*F-P("$]("=P)R`F
M)B!O<&5N;6]D92`A/2!/7U)$5U(I"B$@"0D)"65R<G@H,2P@"B$@"0D)("`@
M(")C86YN;W0@=V]R:R!O;B!R96%D+7=R:71E(&UO=6YT960@9FEL92!S>7-T
M96TB*3L*("`)"0ES=VET8V@@*"IC<"D@>PH@(`H@(`D)"6-A<V4@)T$G.@HJ
M*BHJ*BHJ*BHJ*BHJ*BH**BHJ(#(T."PR-3,@*BHJ*@HM+2T@,C4T+#(V,"`M
M+2TM"B`@"0D)9&5F875L=#H*("`)"0D)=7-A9V4H*3L*("`)"0E]"BL@"0E]
M"B`@"7T*("`):68@*&%R9V,@(3T@,2D*("`)"75S86=E*"D["BHJ*BHJ*BHJ
M*BHJ*BHJ*@HJ*BH@,C<X+#(X.2`J*BHJ"B`@?0H@(`H@('9O:60*(2!G971S
M8BAF<RP@9FEL92D*("`)<F5G:7-T97(@<W1R=6-T(&9S("IF<SL*("`)8VAA
M<B`J9FEL93L*("!["B`@"B$@"69I(#T@;W!E;BAF:6QE+"`R*3L*("`):68@
M*&9I(#P@,"D*("`)"65R<B@S+"`B8V%N;F]T(&]P96X@)7,B+"!F:6QE*3L*
M("`):68@*&)R96%D*"AD861D<E]T*5-"3T9&+"`H8VAA<B`J*69S+"!30E-)
M6D4I*0HM+2T@,C@U+#(Y-R`M+2TM"B`@?0H@(`H@('9O:60*(2!G971S8BAF
M<RP@9FEL92P@;6]D92D*("`)<F5G:7-T97(@<W1R=6-T(&9S("IF<SL*("`)
M8VAA<B`J9FEL93L**R`):6YT(&UO9&4["B`@>PH@(`HA(`EF:2`](&]P96XH
M9FEL92P@;6]D92D["B`@"6EF("AF:2`\(#`I"B`@"0EE<G(H,RP@(F-A;FYO
M="!O<&5N("5S(BP@9FEL92D["B`@"6EF("AB<F5A9"@H9&%D9')?="E30D]&
81BP@*&-H87(@*BEF<RP@4T)325I%*2D*
`
end


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message