From owner-freebsd-commit Sat Sep 16 10:15:29 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA11458 for freebsd-commit-outgoing; Sat, 16 Sep 1995 10:15:29 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA11442 for cvs-all-outgoing; Sat, 16 Sep 1995 10:15:25 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA11432 for cvs-lib-outgoing; Sat, 16 Sep 1995 10:15:23 -0700 Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id KAA11427 ; Sat, 16 Sep 1995 10:15:18 -0700 Received: from localhost (localhost [127.0.0.1]) by precipice.shockwave.com (8.6.12/8.6.12) with SMTP id KAA00186; Sat, 16 Sep 1995 10:14:47 -0700 Message-Id: <199509161714.KAA00186@precipice.shockwave.com> To: Poul-Henning Kamp cc: CVS-commiters@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib Makefile.inc malloc.3 malloc.c free.3 realloc.3 In-reply-to: Your message of "Sat, 16 Sep 1995 02:28:19 PDT." <199509160928.CAA09720@freefall.freebsd.org> Date: Sat, 16 Sep 1995 10:14:46 -0700 From: Paul Traina Sender: owner-commit@FreeBSD.org Precedence: bulk Am I blind, or was there no discussion or code review of this in current or committers first? Malloc/free/sbrk is one of those areas where EVERYONE thinks they can do a better job, and usually they end up screwing up. I don't want a faster malloc(), I want one that's not going to break. There are a bunch of programs that break with gnumalloc(), and that's gotten years of pounding on by a large community. I am extremely unhappy that you've taken it upon yourself to change one of the most complicated and central library functions in FreeBSD without a long testing period by dozens of people and with no way to back out. My suggestion is to back out this change immediately, and create a libpmalloc.a library that you and others who wish to use your malloc may use. Consider me really really really pissed. This isn't a game or anyone's personal system. Paul From: Poul-Henning Kamp Subject: cvs commit: src/lib/libc/stdlib Makefile.inc malloc.3 malloc.c free. >>3 realloc.3 phk 95/09/16 02:28:15 Modified: lib/libc/stdlib Makefile.inc malloc.3 malloc.c Removed: lib/libc/stdlib free.3 realloc.3 Log: ``phkmalloc'' Performance is comparable to gnumalloc if you have sufficient RAM, and it screams around it if you don't. Compiled with "EXTRA_SANITY" until further notice. see malloc.3 for more details.