From owner-svn-src-all@FreeBSD.ORG Tue Dec 9 08:09:57 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CEBE1065675 for ; Tue, 9 Dec 2008 08:09:57 +0000 (UTC) (envelope-from peter@wemm.org) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id E7EA98FC18 for ; Tue, 9 Dec 2008 08:09:56 +0000 (UTC) (envelope-from peter@wemm.org) Received: by an-out-0708.google.com with SMTP id b6so624589ana.13 for ; Tue, 09 Dec 2008 00:09:55 -0800 (PST) Received: by 10.100.153.6 with SMTP id a6mr2003004ane.76.1228810195430; Tue, 09 Dec 2008 00:09:55 -0800 (PST) Received: by 10.100.211.19 with HTTP; Tue, 9 Dec 2008 00:09:55 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2008 00:09:55 -0800 From: "Peter Wemm" To: "Paul Saab" In-Reply-To: <5c0ff6a70812082317t15368b3aibcd6df8d13fcab3e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200812031837.mB3Ib0pb098329@svn.freebsd.org> <5c0ff6a70812082317t15368b3aibcd6df8d13fcab3e@mail.gmail.com> Cc: svn-src-head@freebsd.org, Luigi Rizzo , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r185588 - head/sbin/newfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2008 08:09:57 -0000 On Mon, Dec 8, 2008 at 11:17 PM, Paul Saab wrote: > This requires all devices end in 'a' - 'h'. This breaks newfsing zfs > volumes with arbitrary names, It also would be wrong in a whole bunch of other scenarios: peter@overcee[12:07AM]~/fbp4-1132> cat /etc/fstab /dev/twed0p2 / ufs rw 1 1 /dev/twed0p3 /usr ufs rw 2 2 ... Also.. 'a' .. 'h' is wrong even for disklabel. If you're using GEOM_PART_BSD, you've got something like 20 partition letters available instead of just 8. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell