From owner-freebsd-hackers@FreeBSD.ORG  Sat Feb 12 14:19:27 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0869E106564A;
	Sat, 12 Feb 2011 14:19:27 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de
	[217.11.53.44])
	by mx1.freebsd.org (Postfix) with ESMTP id B74268FC0C;
	Sat, 12 Feb 2011 14:19:26 +0000 (UTC)
Received: from outgoing.leidinger.net (p57B3AEEE.dip.t-dialin.net
	[87.179.174.238])
	by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 691B9844012;
	Sat, 12 Feb 2011 15:19:22 +0100 (CET)
Received: from unknown (IO.Leidinger.net [192.168.2.110])
	by outgoing.leidinger.net (Postfix) with ESMTP id 9C1622085;
	Sat, 12 Feb 2011 15:19:19 +0100 (CET)
Date: Sat, 12 Feb 2011 15:19:18 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Anonymous <swell.k@gmail.com>
Message-ID: <20110212151918.00007489@unknown>
In-Reply-To: <86zkq27ci9.fsf@gmail.com>
References: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net>
	<86zkq27ci9.fsf@gmail.com>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-EBL-MailScanner-Information: Please contact the ISP for more information
X-EBL-MailScanner-ID: 691B9844012.A5A79
X-EBL-MailScanner: Found to be clean
X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN,
	SpamAssassin (not cached, score=-1, required 6, autolearn=disabled,
	ALL_TRUSTED -1.00)
X-EBL-MailScanner-From: alexander@leidinger.net
X-EBL-MailScanner-Watermark: 1298125163.89778@n9RUCpzgYdseYWLf1isOKQ
X-EBL-Spam-Status: No
X-Mailman-Approved-At: Sat, 12 Feb 2011 18:08:25 +0000
Cc: hackers@freebsd.org, kibab@freebsd.org
Subject: Re: CFR: FEATURE macros for
 AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/...
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Feb 2011 14:19:27 -0000

On Fri, 11 Feb 2011 19:38:06 +0300 Anonymous <swell.k@gmail.com> wrote:

> Alexander Leidinger <Alexander@Leidinger.net> writes:
> 
> > Hi,
> >
> > during the last GSoC various FEATURE macros where added to the
> > system. Before committing them, I would like to get some review
> > (like if macro is in the correct file, and for those FEATURES where
> > the description was not taken from NOTES if the description is OK).
> >
> > If nobody complains, I would like to commit this in 1-2 weeks. If
> > you need more time to review, just tell me.
> [...]
> > Index: kern/kern_dtrace.c
> [...]
> > +FEATURE(kdtrace_hooks,
> > +    "Kernel DTrace hooks which are required to load DTrace kernel
> > modules"); +
> [...]
> > Index: kern/kern_lockstat.c
> [...]
> > +FEATURE(kdtrace_hooks, "Kernel DTRACE hooks");
> 
> Why description differs?

Good catch. I removed the second one completely in my working copy.

Bye,
Alexander.