From nobody Sun Feb 1 17:23:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f3xRm6yhGz6Qjxc for ; Sun, 01 Feb 2026 17:23:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f3xRm6DMPz3plJ for ; Sun, 01 Feb 2026 17:23:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769966628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ie/+EdCku39v5G3BXUSSx4muRee0bjnv+MVll4tQJ+w=; b=BjDVbeQfVURlY6bNWYj19Efig/myIpXr+dFa12H7xfLt8kr+MR35dW0f3wDlCamQHKoG+B eDM1kAFGwUvFrUldlkSwjRJPh7wkvOTaNywGNpT0dYVb/kGLQAoTnurA0THo4yDOH1Jfno skoUklpen55zLXftLr0XDxYrlk280tviPOvtfnzXaCl6609uZqq+uFdYBV21mtcMEsO+mG b6n16gCb0g2HESvDhKaaEsjhjmPZUZfWiPgQFvh5uzNWS0Ju2AHV9NbpqOZYebeVOMrqRa TNhh4t4ckKNjyueezbj3/xWNoPpsQrK07l7P1xS6SAiXT5QF4PecuB++XxFyaw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769966628; a=rsa-sha256; cv=none; b=ZMOzbaYl75hPxw32k5T/Mw8PepSJvoaf1O7k9ckiZwSYuu9Y+by4qj8TAfCxpMUDt4zD23 0Mlzc9WB+ugHMraiK7ubWS/vR9g6vBKhgzbSYaratRsc7lmumV6YMoBRRtU6OGBeBrx91a j0HeMRvsqQm3R14gZ3RM3uRzPDU6LZ5xM0sI+G8MXrkb56koaT5CZWLvE83E6YZCRSEPNS cg1QcBvxgQdUrUnHDOLZKy/04Kom1+yZCm55ZyP5XV8POckHYp5U8CSjJaO2s7Fbt1Zlmg 7pIDFrENo/MbMcIhBQ3U+MukUZ93iXdxx8Tzu69sggoOCw9aLwhb+rTsP8Z+zQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769966628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ie/+EdCku39v5G3BXUSSx4muRee0bjnv+MVll4tQJ+w=; b=TSM144A+L3hKWwvWdt3nHxKX26jXIvIVZGM8PzYQeUwcBoDXUgeqVHdlKxK2Rq+Ww12+WO BXW/VAoNCQMHJBUCaIxajQqJVjwZbNmk3EEJ8em6HG4eHAq9TQh0oeFbhiXx5ozJ6nxqLQ /aBaoZcUiiDZCCZUlblGWwWttFjhnwiQIsSYN8K6rEUZXDQk8vC+CrUd08KZgV022aWtLs 1zmiHA/gziKLUwkNXqH//hdAH4Z1avjAWndAxM+deL2LA8ikRprcd1Wj3ht4NKyp9oETVy RBJQlFran+xQ5o3rj38Rs+Nxg3ysGs8KniohSudFYUZ4Lu4sUYOnYEZ1BcOWCQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f3xRm5b6TzqdH for ; Sun, 01 Feb 2026 17:23:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4755f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Feb 2026 17:23:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: Enji Cooper Subject: git: 536ffb491d41 - stable/15 - smartpqi: Avoid declaring extern inline functions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 536ffb491d41c505769897563bed8aa94e2e624a Auto-Submitted: auto-generated Date: Sun, 01 Feb 2026 17:23:48 +0000 Message-Id: <697f8c24.4755f.186e9432@gitrepo.freebsd.org> The branch stable/15 has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=536ffb491d41c505769897563bed8aa94e2e624a commit 536ffb491d41c505769897563bed8aa94e2e624a Author: Mark Johnston AuthorDate: 2026-01-16 19:49:22 +0000 Commit: Enji Cooper CommitDate: 2026-02-01 17:23:10 +0000 smartpqi: Avoid declaring extern inline functions Each C file is compiled separately so these functions can't be inlined except in the file where they are defined. Since these functions aren't used outside smartpqi_request.c, just do the simple thing and make them private to that file. Reported by: gcc Reviewed by: jrhall Fixes: c558eca47970 ("smartpqi: update to version 4660.0.2002") Differential Revision: https://reviews.freebsd.org/D54732 (cherry picked from commit 75c591b26723711d7a38f2a5df7aecc28198cd83) --- sys/dev/smartpqi/smartpqi_prototypes.h | 4 ---- sys/dev/smartpqi/smartpqi_request.c | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_prototypes.h b/sys/dev/smartpqi/smartpqi_prototypes.h index f2eb328b6bc1..fdf69e38fa59 100644 --- a/sys/dev/smartpqi/smartpqi_prototypes.h +++ b/sys/dev/smartpqi/smartpqi_prototypes.h @@ -167,10 +167,6 @@ int pqisrc_send_tmf(pqisrc_softstate_t *, pqi_scsi_dev_t const *, rcb_t *, rcb_t *, int); int pqisrc_write_current_time_to_host_wellness(pqisrc_softstate_t *softs); int pqisrc_write_driver_version_to_host_wellness(pqisrc_softstate_t *softs); -extern inline void pqisrc_aio_build_cdb(aio_req_locator_t *, uint32_t, - rcb_t *, uint8_t *); -extern inline boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *, pqi_scsi_dev_t *, - rcb_t const *, aio_req_locator_t *, uint32_t); void pqisrc_build_aio_common(pqisrc_softstate_t *, pqi_aio_req_t *, rcb_t *, uint32_t); void pqisrc_build_aio_R1_write(pqisrc_softstate_t *, diff --git a/sys/dev/smartpqi/smartpqi_request.c b/sys/dev/smartpqi/smartpqi_request.c index d993897cd1f9..bd2c21954a49 100644 --- a/sys/dev/smartpqi/smartpqi_request.c +++ b/sys/dev/smartpqi/smartpqi_request.c @@ -1492,7 +1492,7 @@ pqisrc_handle_blk_size_diffs(aio_req_locator_t *l) * handle based on dev type, Raid level, and encryption status. * TODO: make limits dynamic when this becomes possible. */ -inline boolean_t +static boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *softs, pqi_scsi_dev_t *device, rcb_t const *rcb, aio_req_locator_t *l, uint32_t disk_blk_cnt) @@ -1636,7 +1636,7 @@ pqisrc_aio_show_locator_info(pqisrc_softstate_t *softs, } /* build the aio cdb */ -inline void +static void pqisrc_aio_build_cdb(aio_req_locator_t *l, uint32_t disk_blk_cnt, rcb_t *rcb, uint8_t *cdb) {