From nobody Mon Jul 7 23:18:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbgCQ1fBvz61V8Z; Mon, 07 Jul 2025 23:18:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbgCN3Wbvz41Vw; Mon, 07 Jul 2025 23:18:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751930304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cboze8yx5UiCuAVFTWv7urE8uAbkt/+SiFKLflu7KXU=; b=Z0RFKXXJnYGINB5alnpg4Vs/U8XyVvFisyVcz83R4wAcm4Fb9XcCe6FUqYbyEvVeZP4eQP Qt/qMs7DjZcTOkK4WLE1ziv0LDqWg7wxvv/feudAa1C+CpaKggn5dnc7cZ3IrTSIP3Z3tb B/ntjIQBRoSxxwXqr6fyJI7dJJLPM2nhkjYYB36dlbl90kfNkbsQ1xPjaI+vXs+V4EUKNp jQtDwE0ahz6ML1gPI7iJmoPzhXI5MboFi+FMi9ghLyyupzqUPBgvk7h3+QngQgCFXJ0TLP Pv+ke6SbxTTGzLe42TwX7jlvOEEPChYdIVwjRrtatv/FGX7jeiNbh/JhuD6+GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751930304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cboze8yx5UiCuAVFTWv7urE8uAbkt/+SiFKLflu7KXU=; b=OI3VdqcSGqnTc42Qra4oZ5paQJghNEVox+jeknqLNTW7Wgr540ZhZ+3Ec7u/WxIfGtQu/7 4zTst/9k+tQarlsO3JFhGTSHCQOpd8T7kizc90fKgE5bASoQO+Z+UiNNrTTBf9haIo3MEk fIOFN1frFmkhhcv5SI78yozGhFoC0i2MOawVN1ceEYWY2D/wFzd56osKLCfzCsy3Gv9PGn ZBjglUM8hSZMpJM9Cxpowveo0EN445/70zVhfNzQxVmz+EO1l9aeN5SIYUEckOqrApgDlh +aiM0lsBjvbPWnHOvRSSAVE692hTWSqgxdy46vQeXqbYScNLhjbja1+l8cZgQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751930304; a=rsa-sha256; cv=none; b=TAgralYAAw2S0cs4NFJQEnfELy6aMl7/vVL011IxX8c8vyeYr4pKphUw95DvvD4yYRMRVt j54bkVJKSOxp1RNnci4Uw7s4FdHAvc6TSjs2xX+07hviDvpbrQctRB3LB8jqYR4sZ25Lk3 GcUAjrs2qcEZ0+IDsABPTF12cIhckzlsBDlVo/gVhuwhNLKGsJ16ubwF7dhVqaWWU6E/yw e2wW0J5aFHCND+NH8JJAv9lmnYm5xt8sSIWvScpuDy3qxiKSVP23s6QtkEu4vK95+SdwoE LiAGprJbKTQDv+HIGtYsETzwozt9fpf2BLK/6HLLMVReBQ6yiiFg67P4mtcVig== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbgCN2y9Mz19YG; Mon, 07 Jul 2025 23:18:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567NIOVL045794; Mon, 7 Jul 2025 23:18:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567NIOHF045791; Mon, 7 Jul 2025 23:18:24 GMT (envelope-from git) Date: Mon, 7 Jul 2025 23:18:24 GMT Message-Id: <202507072318.567NIOHF045791@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 7462eb81cd5b - main - cam: Use bool for done List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7462eb81cd5b2ba6b42e13f49c777a474edea308 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=7462eb81cd5b2ba6b42e13f49c777a474edea308 commit 7462eb81cd5b2ba6b42e13f49c777a474edea308 Author: Warner Losh AuthorDate: 2025-07-07 20:05:16 +0000 Commit: Warner Losh CommitDate: 2025-07-07 23:17:01 +0000 cam: Use bool for done 'done' is a bool, so declare it like one. Sponsored by: Netflix Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D51171 --- sys/cam/scsi/scsi_xpt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/cam/scsi/scsi_xpt.c b/sys/cam/scsi/scsi_xpt.c index 1dd149b00a87..bef35243af98 100644 --- a/sys/cam/scsi/scsi_xpt.c +++ b/sys/cam/scsi/scsi_xpt.c @@ -2183,16 +2183,16 @@ scsi_scan_bus(struct cam_periph *periph, union ccb *request_ccb) * Check to see if we scan any further luns. */ if (next_target) { - int done; + bool done; /* * Free the current request path- we're done with it. */ xpt_free_path(oldpath); hop_again: - done = 0; + done = false; if (scan_info->request_ccb->ccb_h.func_code == XPT_SCAN_TGT) { - done = 1; + done = true; } else if (scan_info->cpi->hba_misc & PIM_SEQSCAN) { scan_info->counter++; if (scan_info->counter == @@ -2201,12 +2201,12 @@ scsi_scan_bus(struct cam_periph *periph, union ccb *request_ccb) } if (scan_info->counter >= scan_info->cpi->max_target+1) { - done = 1; + done = true; } } else { scan_info->counter--; if (scan_info->counter == 0) { - done = 1; + done = true; } } if (done) {