From owner-freebsd-ports-bugs@freebsd.org Sun Dec 30 18:18:55 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59DDD1430946 for ; Sun, 30 Dec 2018 18:18:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D646C8F824 for ; Sun, 30 Dec 2018 18:18:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 99B521430945; Sun, 30 Dec 2018 18:18:54 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 748101430944 for ; Sun, 30 Dec 2018 18:18:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0EB428F822 for ; Sun, 30 Dec 2018 18:18:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 37739E417 for ; Sun, 30 Dec 2018 18:18:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBUIIrad042855 for ; Sun, 30 Dec 2018 18:18:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBUIIrcL042848 for ports-bugs@FreeBSD.org; Sun, 30 Dec 2018 18:18:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234508] sysutils/grub2: Update to recent snapshot, fix build with GCC 8 Date: Sun, 30 Dec 2018 18:18:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords short_desc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2018 18:18:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234508 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch, needs-qa Summary|new port: sysutils/grub2 |sysutils/grub2: Update to |replacement |recent snapshot, fix build | |with GCC 8 Status|New |Open --- Comment #1 from Tobias Kortkamp --- Please make this a unified diff against the existing port. It's harder to see what you changed otherwise. It would also be good to base this on a recent revision (at least the changes and fixes from ports 484145 and ports r488585 appear to not be included here). X ${LOCALBASE}/bin/strip:devel/binutils \ X ${LOCALBASE}/bin/gcc8:lang/gcc8 These changes are wrong and ignore GCC_DEFAULT and other settings. Please use USE_GCC. If it doesn't need gcc at runtime, add RUN_DEPENDS:=3D ${RUN_DEPENDS:Ngcc*} after .include X ${LOCALBASE}/bin/python:lang/python Depending on the lang/python is forbidden by policy. People went through great pains to remove it from all ports, use BINARY_ALIAS=3D python=3D${PYTHON_CMD} if the build calls python directly. XICONV_PREFIX=3D ${LOCALBASE} ICONV_PREFIX is not a port settable variable and should only be set by the framework. It also already set by USES=3Diconv XMAKE_CMD=3D ${LOCALBASE}/bin/gmake Already set by USES=3Dgmake X# Created by: bergerkos@yahoo.co.uk Please retain the original "Created by" line. You did not create this port, sem@ did. You'll get full credit for the update in the commit log. Xpre-configure: X @cd ${WRKSRC} && ${SH} autogen.sh X Why does USES=3Dautoreconf no longer suffice? --=20 You are receiving this mail because: You are the assignee for the bug.=