From owner-freebsd-stable  Tue Mar 27 12:45:19 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50ACD37B719; Tue, 27 Mar 2001 12:45:11 -0800 (PST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id MAA38131;
	Tue, 27 Mar 2001 12:40:49 -0800 (PST)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.11.1/8.11.1) id f2RKeBn44013;
	Tue, 27 Mar 2001 12:40:11 -0800 (PST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200103272040.f2RKeBn44013@arch20m.dellroad.org>
Subject: Re: Kernel Panic on 4.3-RC #0 using PPPoE
In-Reply-To: <4.2.2.20010327070955.01db1268@192.168.0.12> "from Mike Tancsa at
 Mar 27, 2001 07:12:17 am"
To: Mike Tancsa <mike@sentex.net>
Date: Tue, 27 Mar 2001 12:40:11 -0800 (PST)
Cc: freebsd-stable@freebsd.org, freebsd-net@freebsd.org,
	luigi@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL82 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Mike Tancsa writes:
> >Not sure why this hasn't been detected before though. Below is
> >a possible patch.
> 
> It has been at http://www.freebsd.org/cgi/query-pr.cgi?pr=25478 and 
> discussed a few times in freebsd-net.

Here is the better (?) patch. I'd like to commit this if nobody
objects..

Luigi: would you mind reviewing this for possible BRIDGE problems?

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

Index: if_ethersubr.c
===================================================================
RCS file: /home/ncvs/src/sys/net/if_ethersubr.c,v
retrieving revision 1.70.2.15
diff -u -r1.70.2.15 if_ethersubr.c
--- if_ethersubr.c	2001/03/13 22:00:32	1.70.2.15
+++ if_ethersubr.c	2001/03/27 20:39:38
@@ -366,6 +366,11 @@
 {
 	int s, error = 0;
 
+	if ((ifp->if_flags & (IFF_UP|IFF_RUNNING)) != (IFF_UP|IFF_RUNNING)) {
+		m_freem(m);
+		return (ENETDOWN);
+	}
+
 #ifdef BRIDGE
 	if (do_bridge && BDG_USED(ifp) ) {
 		struct ether_header *eh; /* a ptr suffices */

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message