From owner-freebsd-arch  Thu Jan 31  4:40:21 2002
Delivered-To: freebsd-arch@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id B16EF37B404
	for <arch@FreeBSD.ORG>; Thu, 31 Jan 2002 04:40:17 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA13362;
	Thu, 31 Jan 2002 23:37:28 +1100
Date: Thu, 31 Jan 2002 23:38:58 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: "M. Warner Losh" <imp@village.org>
Cc: <drosih@rpi.edu>, <deatley@apple.com>, <arch@FreeBSD.ORG>
Subject: Re: __P macro question
In-Reply-To: <20020130.145424.00452635.imp@village.org>
Message-ID: <20020131231008.P4085-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-arch@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-arch.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-arch>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-arch>
X-Loop: FreeBSD.ORG

On Wed, 30 Jan 2002, M. Warner Losh wrote:

> I'm going through bin right now removing __P() and making the
> functions have new-style rather than old-style decls.  It is a nice
> little mindless thing to do when to relax and unwind.  I plan on
> committing this this weekend (see below).  I've seen nothing so far to
> tell me not to do it:

Don't do it all.  Some people prefer old-style decls, and unlike __P(()),
they don't involve any preprocessor hackery; they are part of ISO C.

Kirks' mail to OpenBSD explicitly said that changing the decls is not
being considered now:

% > In message <200201310328.g0V3Sci74844@beastie.mckusick.com>
% 	so spake Kirk McKusick (mckusick):

% > FreeBSD's current policy is also not to use __P(()) in new code.
% > The current proposal is to simply remove the __P(()), not to convert
% > the function headers (which may be a reasonable thing to do, but is
% > not part of the current plan).

When removing __P(()), don't do it like login/login.c rev.1.80:
- mix the removal with nontrivial rewriting of the code to make it harder
  for auditors to see the critical changes.  Change all the function
  headers too, but don't de-verbosify the code by removing the prototypes
  made redundant by this.
- be sure to unsort the prototypes and add excessive indentation to them.
  Using a low quality script to regenerate all the prototypes is a good
  way to do this.
;-)

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message