From owner-cvs-src@FreeBSD.ORG  Tue Apr 10 16:57:23 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D097516A404;
	Tue, 10 Apr 2007 16:57:23 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id B92C413C487;
	Tue, 10 Apr 2007 16:57:23 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 5B8D31A4D89; Tue, 10 Apr 2007 09:57:29 -0700 (PDT)
Date: Tue, 10 Apr 2007 09:57:29 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Brian Somers <brian@Awfulhak.org>
Message-ID: <20070410165729.GH2382@elvis.mu.org>
References: <200704090219.l392Jc1f064727@repoman.freebsd.org>
	<864pnpdf8w.fsf@dwp.des.no>
	<20070410010901.GD61460@wantadilla.lemis.com>
	<86zm5gr9wl.fsf@dwp.des.no>
	<20070410071256.GJ91694@wantadilla.lemis.com>
	<20070410094659.49041afb@conflict.ca.sophos.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070410094659.49041afb@conflict.ca.sophos.com>
User-Agent: Mutt/1.4.2.2i
Cc: Greg 'groggy' Lehey <grog@FreeBSD.org>, Dag-Erling Sm??rgrav <des@des.no>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/touch touch.1 touch.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2007 16:57:23 -0000

The reason you make it static is so that when you add another file to
the build, there is no need to track down what should be
static.


* Brian Somers <brian@Awfulhak.org> [070410 09:49] wrote:
> On Tue, 10 Apr 2007 16:42:56 +0930
> "Greg 'groggy' Lehey" <grog@FreeBSD.org> wrote:
> 
> > On Tuesday, 10 April 2007 at  9:00:42 +0200, Dag-Erling Smrgrav wrote:
> > > Greg 'groggy' Lehey <grog@FreeBSD.org> writes:
> > >> On Monday,  9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote:
> > >>> The latter part is incorrect and should be reverted.  Furthermore,
> > >>> usage() should be static.
> > >> Can you give details?
> > >
> > > usage() should be the way it was before your commit, except that it
> > > should be static.
> > 
> > You mean declared as a static function?  In a program of a single
> > file?
> > 
> > As I said before,
> > 
> > >> Can you give details?
> > 
> > Specifically, this doesn't match my recollection of "good practice".
> > Where is this behaviour mandated?
> 
> Bump WARNS?  Every function should be either prototyped
> or declared static (or both).
> 
> -- 
> Brian Somers                                       <brian@Awfulhak.org>
> Don't _EVER_ lose your sense of humour !            <brian@FreeBSD.org>

-- 
- Alfred Perlstein