Date: Sun, 13 Jan 2002 04:10:20 -0800 From: Alfred Perlstein <bright@mu.org> To: John Baldwin <jhb@FreeBSD.org> Cc: smp@freebsd.org, dillon@freebsd.org, tanimura@freebsd.org Subject: Re: fd locking. Message-ID: <20020113041019.P7984@elvis.mu.org> In-Reply-To: <20020112191645.J7984@elvis.mu.org>; from bright@mu.org on Sat, Jan 12, 2002 at 07:16:45PM -0800 References: <XFMail.020112174456.jhb@FreeBSD.org> <XFMail.020112185945.jhb@FreeBSD.org> <20020112191645.J7984@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alfred Perlstein <bright@mu.org> [020112 19:17] wrote: > * John Baldwin <jhb@FreeBSD.org> [020112 19:00] wrote: > > > In svr4_stream.c, do_putmsg and do_getmsg should be taking a thread not a proc > > as their first argument and callers should be fixed as well. > > Can this be delayed? Done. > > You might consider a file_init() and file_destroy() function or macro like so: > > Can this be delayed? I personally don't see the need for this, but if you want to do it I'm ok with it. No objections. > > Hmm, do you think you could change fdalloc() to take a filedesc * instead of a > > thread so it's clearer when you lock the old filedesc that it is being used? > > Might work, Can this be delayed? This can't work, we need the proc pointer to enforce open file limits. The limits are stored in the rlimit struct hung off the proc. > > Bruce is going to not like you for adding nested includes of sys/lock.h and > > sys/mutex.h. Instead, add nested includes of sys/_lock.h and sys/_mutex.h, and > > then add sys/lock.h and sys/mutex.h to the files that need them. > > Can this be delayed? I'll start on this. > > Other then that it looks great. Can you clean these bits up and post a new > > patch for folks to test. Aside form svr4, the current patch should be good for > > testing as well. Esp. need people with SMP machines to test this stuff. We'll get that now. :) > I still need to fix Matt's fd holding stuff, but I'm anxious to get this > in before I loose it all to some massive structure renaming or whitespace > run like I have before. :) I have to look at the fget* stuff now as well. thanks, -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020113041019.P7984>