From owner-svn-src-all@freebsd.org Sun Jul 29 01:44:41 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C280B1064CEB for ; Sun, 29 Jul 2018 01:44:41 +0000 (UTC) (envelope-from will@firepipe.net) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B5428A133 for ; Sun, 29 Jul 2018 01:44:41 +0000 (UTC) (envelope-from will@firepipe.net) Received: by mail-qk0-x22f.google.com with SMTP id d22-v6so5712841qkc.8 for ; Sat, 28 Jul 2018 18:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=firepipe-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7FqNfMivF9kSwi16eD6D4SUetLh9MI7avmLICFbiPGM=; b=1gXL4ZC4zurUpBaVwjMjgsri1Zo+qXGx4BT1ykDH119KQVvqEgK/1bhJMkNwsZSQrf KvymfV2cDy6DLaIqh3TISUtfhQFN0eVyHZkeLbDptLjf/HYZl4NUxgu8KzlQtEk6JRLR M+65C6Z9GrJPnA2kvn2R9qQ37dxuEusnnsk2KpvKvHOBYGC985Sy4CRqY8kS3+0WJCbI pwAQ/Cz4i0Jn3iswyfVCQ9vmycizVQ3fg73pkE97ZmiQYMfIeSyKpqtP4rdvPHy57ht0 FalH5FAP9iOs46LOy28De82ajWnr6Tr/UUjwg316uaRCnBzBET08PhBDAE5xjxw1GdbV dlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7FqNfMivF9kSwi16eD6D4SUetLh9MI7avmLICFbiPGM=; b=GXiUQnqNZ0gWBpEZl9qP/Gmb/KCLpSbW4CSu/nF/5sqZjGJk0qQ59YDsVB+r3Es+4M yGak5h0hn/QxHnoOnKEQ76fVk8LU/oueiiYyYBrdQwaIIJFI0aLWTm5GAC3CaZxr1Syw j6RFVdkPhQlXLnfruTBVX+10sN6xNCI+ytvcnc9bcbr4+PgEdtGJEUJu4S2XPhGiaxT4 Iyn+xxREZFpaoWjxhR7YRR2+/MAW+hAVRdE8oNoDk5m93HTFsdwCGjR0EkecY1oh8xJh 7xoWgNmNSIYLCo7E2D55eQ10eF5xR2PJvIhidK7tXqf9qwnej4F2vzQLJVdXsb+PLnuT N+yw== X-Gm-Message-State: AOUpUlFsnS/XvRbSPLl4/DNzXWeEKw6eTyA3HMI0eXXKF1MZGDt1Nefi MGjvsf/hJjhYIn/3QuZBqGJqUKGzT+lm7ZxYjC1CRg== X-Google-Smtp-Source: AAOMgpc4jY1Mmg2lmKz+LvzGhBe9eVmUIFhZZdYEuN3NC6KWe2HbYyH/pHwz6O26r0Mha7b1JM0eHDAijPJpwqjD2iQ= X-Received: by 2002:a37:6249:: with SMTP id w70-v6mr11090564qkb.312.1532828680350; Sat, 28 Jul 2018 18:44:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:3809:0:0:0:0:0 with HTTP; Sat, 28 Jul 2018 18:44:39 -0700 (PDT) In-Reply-To: <0178BAB4-FEFB-473B-9245-3F11ABDA8C09@freebsd.org> References: <201807200044.w6K0i4QQ079894@repo.freebsd.org> <1532108303.1344.57.camel@freebsd.org> <67239C31-11DA-43E0-B282-5AE894C2B0CB@panasas.com> <0178BAB4-FEFB-473B-9245-3F11ABDA8C09@freebsd.org> From: Will Andrews Date: Sat, 28 Jul 2018 20:44:39 -0500 Message-ID: Subject: Re: svn commit: r336526 - head To: Ravi Pokala Cc: Ian Lepore , "src-committers@FreeBSD.org" , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 01:44:42 -0000 Hi Ravi, Thanks for taking an initial stab, I applied your patch and quickly realized the problem is deeper than it looks. This is because installworld and the second stage of mergemaster/etcupdate require the "pre" phase to take effect in their view of the system (specifically, the "ntpd" user must exist from their /etc/passwd, etc). For traditional upgrades, this occurs by simply rebooting. I've committed a revised version of your original patch, and have upgraded across this barrier using beinstall. Please give it a try and let me know how it goes. Thanks! --Will. On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala wrote: > -----Original Message----- > From: Ravi Pokala > Date: 2018-07-20, Friday at 10:53 > To: Ian Lepore , , < > svn-src-all@freebsd.org>, , Will Andrews > > Subject: Re: svn commit: r336526 - head > > > -----Original Message----- > > From: on behalf of Ian Lepore < > ian@freebsd.org> > > Date: 2018-07-20, Friday at 10:38 > > To: Ravi Pokala , , < > svn-src-all@freebsd.org>, > > Subject: Re: svn commit: r336526 - head > > > >> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote: > >>> Hi Ian, > >>> > >>> -----Original Message----- > >>> From: on behalf of Ian Lepore > >>> Date: 2018-07-19, Thursday at 17:44 > >>> To: , , > >>> Subject: svn commit: r336526 - head > >>> > >>>> > >>>> Author: ian > >>>> Date: Fri Jul 20 00:44:04 2018 > >>>> New Revision: 336526 > >>>> URL: https://svnweb.freebsd.org/changeset/base/336526 > >>>> > >>>> Log: > >>>> Add ntpd to the list of users/groups to check before installing. > >>>> > >>>> Modified: > >>>> head/Makefile.inc1 > >>> When trying to installworld: > >>> > >>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING. > >>> > >>> But there is no UPDATING entry about this. (Also, shouldn't it be > ${SRCTOP}/UPDATING?) > >>> > >>> Thanks, > >>> > >>> Ravi (rpokala@) > >> > >> I wondered about that too, when I accidentally stumbled across the > >> CHECK_UIDS thing and realized I should add ntpd to it. I searched in > >> UPDATING for some of the other things in the CHECK_UIDS list to see > >> what had been said about such changes in the past, even searching > >> through old-old svn history, and found nothing. > >> > >> I finally settled on the thought that the reference to UPDATING was to > >> the stuff at the bottom that never changes. In particular to the > >> section around line 1595 that documents the instalkernel, reboot, > >> mergemaster, installworld sequence. The mergemaster part should take > >> care of the new userid, I guess. > >> > >> -- Ian > > > > Interesting. I was attempting the install via the `beinstall.sh' script. > CCing will@, since he wrote it. > > > > Thanks, > > > > Ravi (rpokala@) > > After some discussion on IRC, I created this patch to fix `beinstall.sh'. > > https://people.freebsd.org/~rpokala/beinstall.patch > > However, I'm a bit afraid of testing it, until someone who actually knows > `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-) > > Can anyone take a look and assuage my fears? > > Thanks, > > Ravi (rpokala@) > > >