From nobody Sun Feb 9 16:23:50 2025 X-Original-To: dev-ci@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YrY1f4zrDz5mds3 for ; Sun, 09 Feb 2025 16:24:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YrY1d6ZDRz3h7c; Sun, 09 Feb 2025 16:24:05 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5450cc1669eso164981e87.3; Sun, 09 Feb 2025 08:24:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739118242; x=1739723042; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zNwFv+JAw+ioTuzQcPS9ieA7tV8mTfdyWXS+1CRBKss=; b=euYwMgHBWqP/qwS3DWhQ8NLlBgOySI4IQr9Envvxo9lPaM95m2EnFlElKpEyDSIMgM a+emkdrMgExxN0TF99AG7vAYuaO8D28ukC0oIkqvMm1nnYVew7hs3GrssGu6lS3ytwRA w2BI06v3YWEWpmL3M4DaZJbRfYrRNSP+rhkq7zelzlrmtaA+mFX6g4+s5G8BkgFfX9kd Tk95saox92SIslh5Z1TIyr7DYjedLjEZEG680Tfd8RFaazaTk3vkAbTG5KUg6n4RHWwL g174Fih6mTyzyEEnFO2mnuSdfbvUUPQ1XfJo18WxZNeN811eJzXLuS0Xi9WEZdtj2v4u GLeQ== X-Forwarded-Encrypted: i=1; AJvYcCUhH9ZEezcNSdVA7AmQstrQHxKPmDklX0o2ov4B8jOe5euINEUjqKmVLrzQFNMx8gitsmzTz2A=@freebsd.org X-Gm-Message-State: AOJu0Yx0+0Io1GHQFqvTV5PJGMhfpZ1pqSKurXZJICjzUOg1dNzf5ev2 4tIFujUnNDI0DI4Rv2EmXqvencGM/MQ27f/iIR3TwKH94+x0wJB2PNvbY3lCIil3hjpuUvjzbYy Sk+P1oJBtlarYtkpBHCpJr0VCo0VY9T7U X-Gm-Gg: ASbGncsrvf7lXkwL7ugusMWSlaqibE0rLWNnntNdGkuz3SVocs4VxrCwBqk9X6aeDrZ DJW+RXGpa0n6DydPwxjOhGvHkVRJSNUROQWaaaDgVRiWQKf40N0NKofMrXuL8AjH48Y0muxuUag == X-Google-Smtp-Source: AGHT+IFvuPBGVRk04csj5lYoShYHkf2RkF+au6l2L/IEqUUKNMzI1N3vSMaPxVEouWeBWd2Er+xSqUHo6Qmyi1i8Src= X-Received: by 2002:ac2:54b1:0:b0:545:54b:6a05 with SMTP id 2adb3069b0e04-545054b6ab4mr1532653e87.45.1739118242113; Sun, 09 Feb 2025 08:24:02 -0800 (PST) List-Id: Continuous Integration Build and Test Results List-Archive: https://lists.freebsd.org/archives/dev-ci List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-ci@freebsd.org Sender: owner-dev-ci@FreeBSD.org MIME-Version: 1.0 References: <1655522310.793.1739106980888@jenkins.ci.freebsd.org> <761769956.791.1739106205086@jenkins.ci.freebsd.org> In-Reply-To: From: Adrian Chadd Date: Sun, 9 Feb 2025 08:23:50 -0800 X-Gm-Features: AWEUYZmLrHLSCZFIBCjCxPR2eomAfWQmZ4sPDzMoMPBbkxL8AjnVuvmuKwRI8t4 Message-ID: Subject: Re: FreeBSD-main-amd64-gcc13_build - Build #2837 - Still Failing To: Eygene Ryabinkin Cc: jsm@freebsd.org, dev-ci@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000b317f062db805b1" X-Rspamd-Queue-Id: 4YrY1d6ZDRz3h7c X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] --0000000000000b317f062db805b1 Content-Type: text/plain; charset="UTF-8" hi! markj filed a review - https://reviews.freebsd.org/D48903 We're talking about what/how to fix thanks! -a On Sun, 9 Feb 2025 at 05:47, Eygene Ryabinkin wrote: > Gentlemen, good day. > > Jenkins passed me the following build errors, since I had receintly > committed to the HEAD (ports-committers.dot). My commit was unrelated > to those build failures, but attached is the patch that fixes > the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the > mtw_mcu_cmd(). Also checked that other invocations of mtw_mcu_cmd() > are fine. > > jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM > +0000: > > FreeBSD-main-amd64-gcc13_build - Build #2837 > (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > > > Build information: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/ > > Full change log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes > > Full build log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console > > > > Change summaries: > > (Those commits are likely but not certainly responsible) > > > > c945a7832f94c6a46375596f298f6140640722cd by rea: > > Ports committers: add myself > > > > > > > > The end of the build log: > > > > [...truncated 126.38 MiB...] > [...] > > --- all_subdir_usb/mtw --- > > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > > In function 'mtw_mcu_cmd', > > inlined from 'mtw_mcu_radio' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > > inlined from 'mtw_init_locked' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > > inlined from 'mtw_parent' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' > forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with > type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds=] > > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), > (len)) > > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of > macro 'memcpy' > > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > > | ^~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' declared > here > > 4390 | mtw_init_locked(struct mtw_softc *sc) > > | ^~~~~~~~~~~~~~~ > > > jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM > +0000: > > FreeBSD-main-amd64-gcc12_build - Build #4957 > (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > > > Build information: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/ > > Full change log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes > > Full build log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console > > > > Change summaries: > > (Those commits are likely but not certainly responsible) > > > > c945a7832f94c6a46375596f298f6140640722cd by rea: > > Ports committers: add myself > > > > > > > > The end of the build log: > > > > [...truncated 125.71 MiB...] > [...] > > --- all_subdir_usb/mtw --- > > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > > In function 'mtw_mcu_cmd', > > inlined from 'mtw_mcu_radio' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > > inlined from 'mtw_init_locked' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > > inlined from 'mtw_parent' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' > forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with > type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds] > > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), > (len)) > > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of > macro 'memcpy' > > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > > | ^~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': > > Please, review and, possibly, commit. > > Thank you. > -- > rea > --0000000000000b317f062db805b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=


<= div dir=3D"ltr" class=3D"gmail_attr">On Sun, 9 Feb 2025 at 05:47, Eygene Ry= abinkin <rea@freebsd.org> wrot= e:
Gentlemen, go= od day.

Jenkins passed me the following build errors, since I had receintly
committed to the HEAD (ports-committers.dot).=C2=A0 My commit was unrelated=
to those build failures, but attached is the patch that fixes
the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the
mtw_mcu_cmd().=C2=A0 Also checked that other invocations of mtw_mcu_cmd() are fine.

jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM += 0000:
> FreeBSD-main-amd64-gcc13_build - Build #2837 (c945a7832f94c6a46375596f= 298f6140640722cd) - Still Failing
>
> Build information: https://ci.Fr= eeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/
> Full change log: https://= ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes
> Full build log: https://c= i.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console
>
> Change summaries:
> (Those commits are likely but not certainly responsible)
>
> c945a7832f94c6a46375596f298f6140640722cd by rea:
> Ports committers: add myself
>
>
>
> The end of the build log:
>
> [...truncated 126.38 MiB...]
[...]
> --- all_subdir_usb/mtw ---
> In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:
> In function 'mtw_mcu_cmd',
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_mcu_radio' at /workspace/= src/sys/dev/usb/wlan/if_mtw.c:4387:10,
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_init_locked' at /workspac= e/src/sys/dev/usb/wlan/if_mtw.c:4513:2,
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_parent' at /workspace/src= /sys/dev/usb/wlan/if_mtw.c:3490:3:
> /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy&= #39; forming offset [4, 15] is out of the bounds [0, 4] of object 'val&= #39; with type 'uint32_t' {aka 'unsigned int'} [-Warray-bou= nds=3D]
>=C2=A0 =C2=A0283 | #define memcpy(to, from, len)=C2=A0 =C2=A0__builtin_= memcpy((to), (from), (len))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of= macro 'memcpy'
>=C2=A0 1407 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0memcpy(&sc->txd_f= w[sc->sc_idx]->fw, buf, len);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent&= #39;:
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' d= eclared here
>=C2=A0 4390 | mtw_init_locked(struct mtw_softc *sc)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0| ^~~~~~~~~~~~~~~


jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM += 0000:
> FreeBSD-main-amd64-gcc12_build - Build #4957 (c945a7832f94c6a46375596f= 298f6140640722cd) - Still Failing
>
> Build information: https://ci.Fr= eeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/
> Full change log: https://= ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes
> Full build log: https://c= i.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console
>
> Change summaries:
> (Those commits are likely but not certainly responsible)
>
> c945a7832f94c6a46375596f298f6140640722cd by rea:
> Ports committers: add myself
>
>
>
> The end of the build log:
>
> [...truncated 125.71 MiB...]
[...]
> --- all_subdir_usb/mtw ---
> In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:
> In function 'mtw_mcu_cmd',
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_mcu_radio' at /workspace/= src/sys/dev/usb/wlan/if_mtw.c:4387:10,
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_init_locked' at /workspac= e/src/sys/dev/usb/wlan/if_mtw.c:4513:2,
>=C2=A0 =C2=A0 =C2=A0inlined from 'mtw_parent' at /workspace/src= /sys/dev/usb/wlan/if_mtw.c:3490:3:
> /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy&= #39; forming offset [4, 15] is out of the bounds [0, 4] of object 'val&= #39; with type 'uint32_t' {aka 'unsigned int'} [-Warray-bou= nds]
>=C2=A0 =C2=A0283 | #define memcpy(to, from, len)=C2=A0 =C2=A0__builtin_= memcpy((to), (from), (len))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of= macro 'memcpy'
>=C2=A0 1407 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0memcpy(&sc->txd_f= w[sc->sc_idx]->fw, buf, len);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~ > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent&= #39;:

Please, review and, possibly, commit.

Thank you.
--
rea
--0000000000000b317f062db805b1--