From owner-freebsd-current@FreeBSD.ORG Fri Jan 18 13:34:19 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 22A7C36E; Fri, 18 Jan 2013 13:34:19 +0000 (UTC) (envelope-from satan@ukr.net) Received: from hell.ukr.net (hell.ukr.net [212.42.67.68]) by mx1.freebsd.org (Postfix) with ESMTP id 12C8B879; Fri, 18 Jan 2013 13:34:18 +0000 (UTC) Received: from satan by hell.ukr.net with local ID 1TwC5H-0001uC-Az ; Fri, 18 Jan 2013 15:34:15 +0200 Date: Fri, 18 Jan 2013 15:34:15 +0200 From: Vitalij Satanivskij To: Jaakko Heinonen Subject: Re: panic after r244584 Message-ID: <20130118133415.GA7189@hell.ukr.net> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: satan@ukr.net, Alexander Motin , Gleb Smirnoff , freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2013 13:34:19 -0000 Jaakko Heinonen wrote: JH> On 2013-01-18, Alexander Motin wrote: JH> > > AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) JH> JH> > > AM> The panic is triggered by the check added by the recent r244584 change. JH> > > AM> The space in device name came from the enclosure device, and I guess it JH> > > AM> may be quite often situation. Using human readable name supposed to help JH> > > AM> system administrators, but with spaces banned that may be a problem. JH> > > JH> > > That's was not created by human, it was generated (I think so) by system. JH> > JH> > These strings are flashed into enclosure firmware by manufacturer. JH> JH> You can't rely on that any string can be safely used as a device name JH> even if spaces were allowed. Consider for example duplicate names and JH> "../". JH> JH> Where these names are generated? The original report didn't contain a JH> backtrace. Yes. No backtrace, because of switching off all debuging in kernel. For now I can't use that's server for testing, but there are another servers waiting for upgrade. I will try to reproduce problem with kernel debuger enabled.