From owner-freebsd-current@FreeBSD.ORG  Wed Jun 29 05:54:19 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3402416A424
	for <current@freebsd.org>; Wed, 29 Jun 2005 05:54:19 +0000 (GMT)
	(envelope-from dmp@bitfreak.org)
Received: from mail.bitfreak.org (mail.bitfreak.org [65.75.198.146])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ECABC43D1F
	for <current@freebsd.org>; Wed, 29 Jun 2005 05:54:18 +0000 (GMT)
	(envelope-from dmp@bitfreak.org)
Received: from SMILEY (mail.bitfreak.org [65.75.198.146])
	by mail.bitfreak.org (Postfix) with ESMTP id 4CEA219F3B;
	Tue, 28 Jun 2005 22:56:08 -0700 (PDT)
From: "Darren Pilgrim" <dmp@bitfreak.org>
To: "'Brooks Davis'" <brooks@one-eyed-alien.net>
Date: Tue, 28 Jun 2005 22:54:15 -0700
Message-ID: <001201c57c6e$fcb87140$0b2a15ac@SMILEY>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook, Build 10.0.6626
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2527
In-Reply-To: <20050629053335.GA18808@odin.ac.hmc.edu>
Importance: Normal
Cc: current@freebsd.org
Subject: RE: dhclient/wpa_supplicant patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2005 05:54:19 -0000

From: Brooks Davis
>=20
> --- rc.d/wpa_supplicant	Tue Jun 28 22:24:18 2005
> +++ rc.d/wpa_supplicant	Tue Jun 28 18:51:32 2005
<...>
> +if ! wpaif $ifn; then
> +	return 1
> +fi

I think it would be better if the dhcpif/wpaif test is contained within
netif.  It has to exist in netif because its job is to determine how to
configure the interface.  The dhclient and wpa_supplicant scripts should
be "dumb" single-task scripts to start/stop their respective clients.

By putting the dhcpif/wpaif test in the dhclient/wpa_supplicant scripts,
not only is it redundant, it makes it impossible to use the scripts
manually with an interface that isn't configured in /etc/rc.conf with
the DHCP or WPA magic words.  Such manual operations are useful in
testing, temporary interfaces and custom profile-based configurations
where it's not possible/practical to have a configuration line in
/etc/rc.conf beforehand.