From owner-cvs-all Tue Feb 29 0: 7:36 2000 Delivered-To: cvs-all@freebsd.org Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by hub.freebsd.org (Postfix) with ESMTP id E77E637C17C; Tue, 29 Feb 2000 00:07:18 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id SAA18625; Tue, 29 Feb 2000 18:37:08 +1030 (CST) Date: Tue, 29 Feb 2000 18:37:07 +1030 From: Greg Lehey To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumrequest.c Message-ID: <20000229183706.D16629@freebie.lemis.com> References: <200002290614.WAA16809@freefall.freebsd.org> <20000229002459.B21720@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <20000229002459.B21720@fw.wintelcom.net> WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tuesday, 29 February 2000 at 0:25:00 -0800, Alfred Perlstein wrote: > * Greg Lehey [000228 22:45] wrote: >> grog 2000/02/28 22:14:45 PST >> >> Modified files: >> sys/dev/vinum vinumrequest.c >> Log: >> launch_requests: If too many requests are active, include PCATCH in >> the tsleep call flags. >> >> Submitted-by: Bernd Walter > > grrr! > > while ((drive->active >= DRIVE_MAXACTIVE) /* it has too much to do already, */ >>> (vinum_conf.active >= VINUM_MAXACTIVE)) /* or too many requests globally */ > - tsleep(&launch_requests, PRIBIO, "vinbuf", 0); /* wait for it to subside */ > + tsleep(&launch_requests, PRIBIO | PCATCH, "vinbuf", 0); /* wait for it to subside */ > drive->active++; > > please back this out, i've already fixed this twice, if you actually > get a signal you'll spin in the kernel. > > the correct solution must check the return from tsleep and actually > do something with an error return, for now we've agreed to ignore > signals until a safe return can be implemented. PCATCH must be > removed. OK, make a suggestion. The trouble is, you and Bernd keep asking for opposite things, and I was getting out of phase on the whole matter. In any case, another change I made (MAXREQUESTS = 30000) means that we'll never call tsleep here. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message