From nobody Sun Feb 1 17:29:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f3xZQ2sWTz6QkRr for ; Sun, 01 Feb 2026 17:29:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f3xZQ22GNz3q5Q for ; Sun, 01 Feb 2026 17:29:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769966974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wetwb6BhInk+AxIJbhw5GrtxX5cU2w6tTKRTHbtRnNw=; b=AFkv+l/Oyu/JH89p+Nzyu/DnxXfbanT4b6dkjxV9CPI1EZ/p3deY06vCRF+mnhxQi5GJ71 d53kfZ0KcgWWhidifeonseRIyo2SBHXtrN94R+Y0jGTUC0XxPtYeby+ewHhxEm2Oqt5iCy GK+y2YlMdXfah2KPQWibpGE1utjZVd2V1moUCfydNnZbRabI92AZM2MEfAS+YH8sy7O3cp UwzAz8WR12ut2BGjMwnr7n9ed+/ybMB2uaWNuDx+REttjyGhDFw4b7ScNzoisGCKc3rV2u ui9sh/m46xvZl40YtTr0fzMHAawcvpL1/OO2DfnmqUdZfQ4lXv+1hTlrV2ruXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769966974; a=rsa-sha256; cv=none; b=Vg6kCCJSGrWjpt3zXLltrLf9MPwvNQcSQzhsP9UDMK4A/xEUFPC7V/rtohDk5AwcgX9Jdw XnnSe34TPfF5CEpufmwg1gMwBTAuF5o/U8GjbE6IubDb2+0Sx35Yb/ATcqEcuaDDLgs75K rFH/YSG9isLiSNmWEltz+U1QJn7BqgDEr5uRPU1edJq66TWp/2nvpcuYI2MeSBXxLmbBrM NssQERVcsXFpevdgHOZgi1ltqtFJu4P2LCog48bHGqEoeZ1QN2CTvXAHDNBBNrfFjvgeBc 59pzYnbtCd2leCs0jvkrpGvLSg4gqmYuJXWkNCZqVMs3enzrLWEjFEsZHOjncA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769966974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wetwb6BhInk+AxIJbhw5GrtxX5cU2w6tTKRTHbtRnNw=; b=hnJVzsLPL7PrnJ0wJ4qKpl40+FBqyP2T6ULTTBWvkGbEZ/8RII0wD0eSnTRvFyJWDeLF+C QTLHeYhUOYff/NXeiIwpPaKXr9rTCEvNZNrKr9OJYrG2uJIhaYc4xDwPG2h9nMnGMNoOP5 i5x2Uw61K/eV1s3HTPadMlUwzabGalJpmzSUVsXWU22NdB8svki9FvscNLwBdkXbSACY/e gZAjJCCX2LcFrhL8iZ0zKmkn+1yTyN4dxJYyTT4t/NMHJPbF8huHr6nhRG4tBC4LkCGU/o Y4pDmfJkgjz9n0vRqt/w4wkNryphQZ5vU8K6tpVSk2Qb1+afepentM75/ese2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f3xZQ13bVzqZm for ; Sun, 01 Feb 2026 17:29:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 194a9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 01 Feb 2026 17:29:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Yogesh Bhosale From: Kevin Bowling Subject: git: 98bdf63f6e94 - main - ice(4): Handle allmulti flag in ice_if_promisc_set function List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 98bdf63f6e94be42a1787de73608de15bcb3419a Auto-Submitted: auto-generated Date: Sun, 01 Feb 2026 17:29:34 +0000 Message-Id: <697f8d7e.194a9.6742a8dc@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=98bdf63f6e94be42a1787de73608de15bcb3419a commit 98bdf63f6e94be42a1787de73608de15bcb3419a Author: Yogesh Bhosale AuthorDate: 2026-02-01 17:27:36 +0000 Commit: Kevin Bowling CommitDate: 2026-02-01 17:27:36 +0000 ice(4): Handle allmulti flag in ice_if_promisc_set function In the ice_if_promisc_set function, the driver currently disables the IFF_ALLMULTI flag, thereby preventing the activation of multicast mode. To address this issue, implement appropriate handling to ensure the flag is managed correctly. Signed-off-by: Yogesh Bhosale Tested by: Gowthamkumar K S MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54186 --- sys/dev/ice/if_ice_iflib.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/sys/dev/ice/if_ice_iflib.c b/sys/dev/ice/if_ice_iflib.c index 1469d2916465..6ea539d52e02 100644 --- a/sys/dev/ice/if_ice_iflib.c +++ b/sys/dev/ice/if_ice_iflib.c @@ -1907,15 +1907,13 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) ice_set_default_promisc_mask(promisc_mask); - if (multi_enable) - return (EOPNOTSUPP); - if (promisc_enable) { status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, promisc_mask, 0); if (status && status != ICE_ERR_ALREADY_EXISTS) { device_printf(dev, - "Failed to enable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to enable promiscuous mode for " + "PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); @@ -1925,11 +1923,28 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) promisc_mask, 0); if (status) { device_printf(dev, - "Failed to disable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to disable promiscuous mode for" + " PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); } + + if (multi_enable) { + ice_clear_bit(ICE_PROMISC_UCAST_TX, promisc_mask); + ice_clear_bit(ICE_PROMISC_UCAST_RX, promisc_mask); + status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, + promisc_mask, 0); + if (status && status != ICE_ERR_ALREADY_EXISTS) { + device_printf(dev, + "Failed to enable allmulti mode " + "for PF VSI, err %s aq_err %s\n", + ice_status_str(status), + ice_aq_str( + hw->adminq.sq_last_status)); + return (EIO); + } + } } return (0);