Date: Fri, 15 Jul 2016 10:27:22 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: devel/sope: make (stage-qa) now fails with DEVELOPER=yes complaining about iconv dependency Message-ID: <59cc8584-df17-4c34-0ad5-531e0eb9128b@freebsd.org> In-Reply-To: <709bb40d-1c08-4658-eb32-a2d280b0281d@utanet.at> References: <a9c1c4ab-b040-5412-1570-b2ae9f34723a@FreeBSD.org> <709bb40d-1c08-4658-eb32-a2d280b0281d@utanet.at>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9iAQwQM3eqOXQqnoehpJtL0xsqaPqMn84 Content-Type: multipart/mixed; boundary="a5nrlsdLkROb34IwEcJud5JQcOOveskrh" From: Matthew Seaman <matthew@freebsd.org> To: freebsd-ports@freebsd.org Message-ID: <59cc8584-df17-4c34-0ad5-531e0eb9128b@freebsd.org> Subject: Re: devel/sope: make (stage-qa) now fails with DEVELOPER=yes complaining about iconv dependency References: <a9c1c4ab-b040-5412-1570-b2ae9f34723a@FreeBSD.org> <709bb40d-1c08-4658-eb32-a2d280b0281d@utanet.at> In-Reply-To: <709bb40d-1c08-4658-eb32-a2d280b0281d@utanet.at> --a5nrlsdLkROb34IwEcJud5JQcOOveskrh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/16 09:37, Walter Schwarzenfeld wrote: > It is a bug the statement is wrong. > The error message disappiear if you add to LIB_DEPENDS > libiconv.so:converters/libiconv. >=20 > Btw. > it says > Error: /usr/local/GNUstep/Local/Library/Libraries/libNGStreams.so.4.9.5= 7 > is linked to /usr/local/lib/libssl.so.38 from security/libressl but it > is not declared as a dependency > Warning: you need USES=3Dssl > Error: /usr/local/GNUstep/Local/Library/Libraries/libNGStreams.so.4.9.5= 7 > is linked to /usr/local/lib/libcrypto.so.37 from security/libressl but > it is not declared as a dependency > Warning: you need USES=3Dssl >=20 >=20 > if I add ssl to USES > it states > you may not need USES+=3Dssl. >=20 > I am not happy with the "new" stage-qa messages. I agree that this is annoying, and I wish there was some way to tell stage-qa that the library dependencies are in fact OK. The problem here is the heuristic used to determine whether there are any missing library dependencies. This simply uses readelf(1) to find out what's required by the dynamic loader for all of the binaries included in the port. If it finds that an application 'foo' requires a shared library libbar it will tell you 'you need USES+=3Dbar' Much of th= e time this is correct, and a handy sanity check. However, what seems to happen fairly often is that foo only has a direct dependency on libbaz and libbaz is what links against libbar. foo doesn't know anything about functions and objects provided by libbar or use any of them itself, except through the interface provided by libbaz, so foo's dependency on libbar is entirely indirect. In this situation I can't see why the port foo should list an explicit dependency on libbar; the one it inherits through libbaz seems to me to express the linkage between foo and libbar in an entirely satisfactory wa= y. You should only get the 'you may not need USES+=3Dfoo' message when you'v= e added the dependency in the ports Makefile, but none of the resulting binaries link against libfoo. I don't see how you are getting the results you describe there. Cheers, Matthew --a5nrlsdLkROb34IwEcJud5JQcOOveskrh-- --9iAQwQM3eqOXQqnoehpJtL0xsqaPqMn84 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXiKx7AAoJEABRPxDgqeTnJyEP/R3Uk1A2/BYZaTANfbN5ecDs R64lQXTDvU5e9czYMlxlj3smerbB74SVP3ryVZHjwe4JwdzLj/b5Of4GmhehU42u jMy4bLtLjY8LIZNp29vSfNs1Snl85kTsOm+XuP9btI5hWld8sqPOFpIND43ZiX5t bYk4yhVsyEvtppFG79lW51+GbsbOR+1MnuWYAJ7kB3b79HaeddDSJ1axu3HUDnxi gDpYNBzum3Rg9WY44nGa5h/n9sYsvgSbEAGGzZ3jo+8sd4Cm9HC3NxynTJpEgLWF bTuSvldiMQO1UTVPpTCGxgTlTWoi11rIuNVda/xSJXZxWFodPchCnq7pJ89ZrGZf oEDMBP+uVclMBrMto2DhHURRhMjgK4FKOJLAAIEQOLO6CwAiD56x3Gexk+23jtnm IoOBDewt8f2t7RfVHzZoat2O/Q8CWJDmgD3PYqOSiLO4F1eIO+FETYSkC8kzNfKb hfl5cwlpeuQYm6xZL0TimMiz9D50Wt+nUNLvzPRHcjOzrGFnwvf0w8yfpZtRCoCR 1+1F7lbhNh4KwhFg7qHMMgrNbfFpfXuq2r3OTzagTjFhbfeU2uVoqxvNWqM2uVfn b1E0DD92obNk32bk1Imvy7RlZk7XVSIPnr9RQRGZ6r2q1iUKl8UL9sqxZYZlfgat Rhzgi4OskvScaQ1WpYvu =eEoe -----END PGP SIGNATURE----- --9iAQwQM3eqOXQqnoehpJtL0xsqaPqMn84--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?59cc8584-df17-4c34-0ad5-531e0eb9128b>