From owner-freebsd-bugs@FreeBSD.ORG  Mon Aug 25 13:00:43 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3440A16A4BF
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 25 Aug 2003 13:00:43 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E869843F75
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 25 Aug 2003 13:00:40 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7PK0eUp050370
	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 25 Aug 2003 13:00:40 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7PK0evT050369;
	Mon, 25 Aug 2003 13:00:40 -0700 (PDT)
Date: Mon, 25 Aug 2003 13:00:40 -0700 (PDT)
Message-Id: <200308252000.h7PK0evT050369@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Robert Watson <rwatson@FreeBSD.org>
Subject: Re: kern/55886: mbuf exhaustion can cause panic
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Robert Watson <rwatson@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2003 20:00:43 -0000

The following reply was made to PR kern/55886; it has been noted by GNATS.

From: Robert Watson <rwatson@FreeBSD.org>
To: Pawel Malachowski <pawmal-posting@freebsd.lublin.pl>
Cc: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: kern/55886: mbuf exhaustion can cause panic
Date: Mon, 25 Aug 2003 15:52:46 -0400 (EDT)

 Try the attached patch for -CURRENT, or variation on -STABLE.  Basically,
 M_PREPEND() can fail leaving (m == NULL) even with M_TRYWAIT.  Most
 consumers of M_PREPEND seem to know that.  Raw IP output seems not to.
 
 Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
 robert@fledge.watson.org      Network Associates Laboratories
 
 Index: raw_ip.c
 ===================================================================
 RCS file: /data/fbsd-cvs/ncvs/src/sys/netinet/raw_ip.c,v
 retrieving revision 1.114
 diff -u -r1.114 raw_ip.c
 --- raw_ip.c	20 Aug 2003 14:46:40 -0000	1.114
 +++ raw_ip.c	25 Aug 2003 19:50:07 -0000
 @@ -288,6 +288,8 @@
  			return(EMSGSIZE);
  		}
  		M_PREPEND(m, sizeof(struct ip), M_TRYWAIT);
 +		if (m == NULL)
 +			return(ENOBUFS);
  		ip = mtod(m, struct ip *);
  		ip->ip_tos = inp->inp_ip_tos;
  		ip->ip_off = 0;