From owner-svn-src-head@FreeBSD.ORG  Thu Sep  3 14:22:14 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 48829106566B;
	Thu,  3 Sep 2009 14:22:14 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id EF7958FC12;
	Thu,  3 Sep 2009 14:22:13 +0000 (UTC)
Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57])
	(authenticated bits=0)
	by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n83EMAOV088445;
	Thu, 3 Sep 2009 08:22:10 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Mime-Version: 1.0 (Apple Message framework v1075.2)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
From: Scott Long <scottl@samsco.org>
In-Reply-To: <200909031237.n83CbIgk032551@svn.freebsd.org>
Date: Thu, 3 Sep 2009 08:22:10 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <1872D962-9297-4C45-9F73-4BB823C49D74@samsco.org>
References: <200909031237.n83CbIgk032551@svn.freebsd.org>
To: Alexander Motin <mav@freebsd.org>
X-Mailer: Apple Mail (2.1075.2)
X-Spam-Status: No, score=-3.3 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00
	autolearn=ham version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r196777 - head/sys/dev/ahci
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2009 14:22:14 -0000

In this case, set maxio to 64k, not 127.5k.  You'll typically get much  
better i/o performance out of two 64k transfers
than you will out of one 127.k transfer and one 512 bytes transfer,  
which is what the block layer will give you if
you try to send 128k.

Scott



On Sep 3, 2009, at 6:37 AM, Alexander Motin wrote:

> Author: mav
> Date: Thu Sep  3 12:37:17 2009
> New Revision: 196777
> URL: http://svn.freebsd.org/changeset/base/196777
>
> Log:
>  ATI SB600 can't handle 256 sectors transfers with FPDMA (NCQ).
>
>  MFC after:	3 days
>
> Modified:
>  head/sys/dev/ahci/ahci.c
>
> Modified: head/sys/dev/ahci/ahci.c
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- head/sys/dev/ahci/ahci.c	Thu Sep  3 10:06:37 2009	(r196776)
> +++ head/sys/dev/ahci/ahci.c	Thu Sep  3 12:37:17 2009	(r196777)
> @@ -1942,6 +1942,9 @@ ahciaction(struct cam_sim *sim, union cc
> 		cpi->protocol = PROTO_ATA;
> 		cpi->protocol_version = PROTO_VERSION_UNSPECIFIED;
> 		cpi->maxio = MAXPHYS;
> +		/* ATI SB600 can't handle 256 sectors with FPDMA (NCQ). */
> +		if (pci_get_devid(device_get_parent(dev)) == 0x43801002)
> +			cpi->maxio = min(cpi->maxio, 255 * 512);
> 		cpi->ccb_h.status = CAM_REQ_CMP;
> 		xpt_done(ccb);
> 		break;