Date: Thu, 7 Nov 2013 02:43:22 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ganael LAPLANCHE <martymac@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332953 - head/benchmarks/nttcp Message-ID: <20131107024322.GA63635@FreeBSD.org> In-Reply-To: <20131106135212.M16907@FreeBSD.org> References: <201311060811.rA68BbBe077262@svn.freebsd.org> <20131106081815.GB90001@FreeBSD.org> <20131106135212.M16907@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 06, 2013 at 01:55:14PM +0000, Ganael LAPLANCHE wrote:
> On Wed, 6 Nov 2013 08:18:15 +0000, Alexey Dokuchaev wrote
>
> Hi Alexey,
> > > ALL_TARGET= nttcp
> > > -MAN1= nttcp.1
> > > -PLIST_FILES= bin/nttcp
> > > +PLIST_FILES= bin/nttcp man/man1/nttcp.1.gz
> >
> > We usually try to move out PLIST_* knobs in separate block.
>
> You mean having a blank line between MAN1 and PLIST_FILES, right ?
Well, since now MAN1 line is gone, it would be blank line between ALL_TARGET
and PLIST_FILES.
> > > - ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/
> > > - ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/
> > > + ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/
> > > + ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/
> >
> > Manual pages should be installed relative to MAN[n]PREFIX, not
> > PREFIX.
>
> Oops, thanks for having spotted this ! I'll fix that ASAP.
Thanks.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131107024322.GA63635>