From owner-cvs-all Tue Oct 3 9:40:16 2000 Delivered-To: cvs-all@freebsd.org Received: from jade.chc-chimes.com (jade.chc-chimes.com [216.28.46.6]) by hub.freebsd.org (Postfix) with ESMTP id DA19037B503; Tue, 3 Oct 2000 09:40:12 -0700 (PDT) Received: by jade.chc-chimes.com (Postfix, from userid 1001) id DFDA11C6B; Tue, 3 Oct 2000 12:40:11 -0400 (EDT) Date: Tue, 3 Oct 2000 12:40:11 -0400 From: Bill Fumerola To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <20001003124011.T38472@jade.chc-chimes.com> References: <200010031218.FAA51112@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <200010031218.FAA51112@freefall.freebsd.org>; from ru@FreeBSD.org on Tue, Oct 03, 2000 at 05:18:11AM -0700 X-Operating-System: FreeBSD 3.3-STABLE i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Oct 03, 2000 at 05:18:11AM -0700, Ruslan Ermilov wrote: > Modified files: > sys/netinet ip_fw.c > Log: > Added the missing ntohs() conversion when matching IP packet with > the IP_FW_IF_IPID rule. (We have recently decided to keep the > ip_id field in network byte order inside the kernel, see revision > 1.140 of src/sys/netinet/ip_input.c). Crappy. I haven't been following -current as closely as possible. > I did not like to have the conversion happen in userland, and I > think that the similar conversions for fw_tcp(seq|ack|win) should > be moved out of userland (src/sbin/ipfw/ipfw.c) into the kernel. That's fine, I was just trying to save CPU (perhaps needlessly) by doing the conversion when we store it as opposed to when we check it. -- Bill Fumerola - Network Architect, BOFH / Chimes, Inc. billf@chimesnet.com / billf@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message