From owner-svn-src-all@freebsd.org Mon Oct 26 19:52:30 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EA28044D58A; Mon, 26 Oct 2020 19:52:29 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CKlqH3bZVz4g3f; Mon, 26 Oct 2020 19:52:26 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 09QJqFUa031816 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 26 Oct 2020 12:52:16 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 09QJqFZR031814; Mon, 26 Oct 2020 12:52:15 -0700 (PDT) (envelope-from jmg) Date: Mon, 26 Oct 2020 12:52:15 -0700 From: John-Mark Gurney To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367048 - head/lib/libc/sys Message-ID: <20201026195215.GA31099@funkthat.com> Mail-Followup-To: John-Mark Gurney , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010260037.09Q0bVpN090953@repo.freebsd.org> <202010260059.09Q0xbxt003944@slippy.cwsent.com> <202010260104.09Q14Kmq004045@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010260104.09Q14Kmq004045@slippy.cwsent.com> X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Mon, 26 Oct 2020 12:52:16 -0700 (PDT) X-Rspamd-Queue-Id: 4CKlqH3bZVz4g3f X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [-0.48 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jmg]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.14)[0.138]; NEURAL_HAM_LONG(-0.87)[-0.869]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.95)[-0.954]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 19:52:32 -0000 Cy Schubert wrote this message on Sun, Oct 25, 2020 at 18:04 -0700: > In message <202010260059.09Q0xbxt003944@slippy.cwsent.com>, Cy Schubert > writes: > > In message <202010260037.09Q0bVpN090953@repo.freebsd.org>, John-Mark Gurney > > wri > > tes: > > > Author: jmg > > > Date: Mon Oct 26 00:37:31 2020 > > > New Revision: 367048 > > > URL: https://svnweb.freebsd.org/changeset/base/367048 > > > > > > Log: > > > update write(2)'s iovec limit w/ info about the iosize_max_clamp sysctl.. > > . > > > > > > Modified: > > > head/lib/libc/sys/write.2 > > > > > > Modified: head/lib/libc/sys/write.2 > > > =========================================================================== > > == > > > = > > > --- head/lib/libc/sys/write.2 Sun Oct 25 23:26:07 2020 (r36704 > > 7) > > > +++ head/lib/libc/sys/write.2 Mon Oct 26 00:37:31 2020 (r36704 > > 8) > > > @@ -28,7 +28,7 @@ > > > .\" @(#)write.2 8.5 (Berkeley) 4/2/94 > > > .\" $FreeBSD$ > > > .\" > > > -.Dd March 30, 2020 > > > +.Dd October 25, 2020 > > > .Dt WRITE 2 > > > .Os > > > .Sh NAME > > > @@ -240,9 +240,13 @@ array was negative. > > > .It Bq Er EINVAL > > > The sum of the > > > .Fa iov_len > > > -values in the > > > -.Fa iov > > > -array overflowed a 32-bit integer. > > > +values is greater than > > > +.Dv SSIZE_MAX > > > +(or greater than > > > +.Dv INT_MAX , > > > +if the sysctl > > > +.Va debug.iosize_max_clamp > > > > Should we also include SEE ALSO reference to sysctl(8) or sysctl(3)? > > Personally I think a reference to sysctl(8) would be more apropos. > > Or maybe both. Yeah, I was thinking the same thing myself, but decided to go with a minimal change. I was thinking of making the mention of sysctl in the body an Xr in addition to a SEE ALSO, but I couldn't decide which of 3 or 8. I guess the Xr in the body would be 3. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."