Date: Mon, 3 Jul 2023 22:36:53 -0600 From: Warner Losh <imp@bsdimp.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA@mail.gmail.com> In-Reply-To: <1767168745.2134945.1688443634249@mail.yahoo.com> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> <1767168745.2134945.1688443634249@mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c4b79205ffa1d586
Content-Type: text/plain; charset="UTF-8"
On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <pfg@freebsd.org> wrote:
> (Sorry for top posting)
>
> Oh yes, the analysis is fine, and it is quicker to fix than what I had in
> mind.
>
> I'll take a look at fixing it now, but due to external issues I may have
> to leave the fix for next weekend.
>
Ah great. I'll not have time to fix this... thanks for taking care of
this... sorry if i was a It grumpy... it's been a day...
Warner
Pedro.
>
>
> On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <imp@bsdimp.com>
> wrote:
>
>
>
>
> On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
>
> Hmm ...
>
> Dragonfly has no armv7 or i386, so they didn't get it too wrong.
> I guess the int64_t would be a quick fix or another option, which I was
> consideirng, was to look at unsigning it but taking care of the edge cases
> ... I was too lazy for that.
>
> Please go ahead and do the quick fix ;)
>
>
> What makes you say it's a quick fix? If the calculations need 64 bits,
> int64_t is the proper data type. How is that analysis wrong?
>
> Also, it's tradition that you should fix it...
>
> Warner
>
--000000000000c4b79205ffa1d586
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <<a hre=
f=3D"mailto:pfg@freebsd.org">pfg@freebsd.org</a>> wrote:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc=
solid;padding-left:1ex"><div><div style=3D"font-family:Helvetica Neue,Helv=
etica,Arial,sans-serif;font-size:16px"><div></div>
<div dir=3D"ltr">(Sorry for top posting)</div><div><br></div><div d=
ir=3D"ltr">Oh yes, the analysis is fine, and it is quicker to fix than what=
I had in mind.</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">I'll t=
ake a look at fixing it now, but due to external issues I may have to leave=
the fix for next weekend.</div></div></div></blockquote></div></div><div d=
ir=3D"auto"><br></div><div dir=3D"auto">Ah great. I'll not have time to=
fix this... thanks for taking care of this... sorry if i was a It grumpy..=
. it's been a day...</div><div dir=3D"auto"><br></div><div dir=3D"auto"=
>Warner</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gm=
ail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex"><div><div style=3D"font-family:He=
lvetica Neue,Helvetica,Arial,sans-serif;font-size:16px"><div dir=3D"ltr">Pe=
dro.</div><div><br></div><div><br></div>
=20
</div><div id=3D"m_-2495992665827709045ydp39addca9yahoo_quoted_9236=
065441">
<div style=3D"font-family:'Helvetica Neue',Helvetica,Ar=
ial,sans-serif;font-size:13px;color:#26282a">
=20
<div>
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Lo=
sh <<a href=3D"mailto:imp@bsdimp.com" target=3D"_blank" rel=3D"noreferre=
r">imp@bsdimp.com</a>> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id=3D"m_-2495992665827709045ydp39addca9yiv4277734=
352"><div><div><div><br clear=3D"none"><br clear=3D"none"><div><div dir=3D"=
ltr">On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <<a shape=3D"rect" href=
=3D"mailto:pfg@freebsd.org" rel=3D"nofollow noreferrer" target=3D"_blank">p=
fg@freebsd.org</a>> wrote:<br clear=3D"none"></div><blockquote style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div st=
yle=3D"font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:16px=
"><div></div>
<div dir=3D"ltr">Hmm ...</div><div dir=3D"ltr"><br clear=3D"none"><=
/div><div dir=3D"ltr">Dragonfly has no armv7 or i386, so they didn't ge=
t it too wrong.</div><div dir=3D"ltr">I guess=C2=A0<span><span style=3D"col=
or:rgb(0,0,0);font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-si=
ze:16px">the int64_t would be a quick fix or</span></span> another option, =
which I was consideirng, was to look at unsigning it but taking care of the=
edge cases ... I was too lazy for that.</div><div><br clear=3D"none"></div=
><div dir=3D"ltr">Please go ahead and do the quick fix ;)</div></div></div>=
</blockquote></div></div><div><br clear=3D"none"></div><div>What makes you =
say it's a quick fix? If the calculations need 64 bits, int64_t is the =
proper data type. How is that analysis wrong?</div><div><br clear=3D"none">=
</div><div>Also, it's tradition that you should fix it...</div><div><br=
clear=3D"none"></div><div>Warner</div></div><div id=3D"m_-2495992665827709=
045ydp39addca9yiv4277734352yqtfd43229">
</div></div></div></div>
</div>
</div></div></blockquote></div></div></div>
--000000000000c4b79205ffa1d586--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA>