From owner-freebsd-net@freebsd.org Fri Jan 8 15:59:17 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E129A67B4E for ; Fri, 8 Jan 2016 15:59:17 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7C1761AAB for ; Fri, 8 Jan 2016 15:59:17 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-24-6-178-251.hsd1.ca.comcast.net [24.6.178.251]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.36.0 64bit (built Sep 8 2015)) with ESMTPSA id <0O0N00GYO5QMJU20@mr11p00im-asmtp002.me.com> for freebsd-net@freebsd.org; Fri, 08 Jan 2016 15:59:11 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-01-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510270003 definitions=main-1601080263 User-Agent: Microsoft-MacOutlook/0.0.0.151217 Date: Fri, 08 Jan 2016 07:59:09 -0800 Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth From: Ravi Pokala Sender: "Pokala, Ravi" To: "freebsd-net@freebsd.org" Message-id: Thread-topic: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 15:59:17 -0000 -----Original Message----- >Date: Fri, 8 Jan 2016 02:29:22 +0000 >From: "sepherosa_gmail.com (Sepherosa Ziehau)" > >To: freebsd-net@freebsd.org >Subject: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network > driver configurable LRO entry depth >Message-ID: > >Content-Type: text/plain; charset="utf-8" > >sepherosa_gmail.com created this revision. >sepherosa_gmail.com added reviewers: network, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, glebius. >sepherosa_gmail.com added a subscriber: freebsd-net-list. >Herald added a reviewer: transport. > >REVISION SUMMARY > When there is only tiny amount of TCP connections and the host is slow, e.g. in VM, holding too much TCP segments in an LRO entry will cause RX performance degradation. We now allow network drivers to configure how deep one LRO entry should be. Forgive me if I'm missing something obvious, but this patch doesn't actually change anything - rather than hard-coding 65535, you're using lc->lro_hiwat... which is hard-coded to 65535. Right? -Ravi (rpokala@)