From owner-svn-src-head@freebsd.org Tue Dec 31 02:38:00 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 152521F1153; Tue, 31 Dec 2019 02:38:00 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mz476ngXz3HPJ; Tue, 31 Dec 2019 02:37:59 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f65.google.com with SMTP id b18so26811064otp.0; Mon, 30 Dec 2019 18:37:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=MRCCLJFzavbHp7S9J8bIJAs9cBXeaBPTzteJKalLUpg=; b=uocS4KilCupfcviYnh0MRVMGlg+Cu8R76NE4U0dou2yajfM/pKf3jWphelEolWdgd1 bCggm8t1djTzewbvMGo15k6kCBMO4PzXqzEfjoGMEyvUDAXTkrHk1GDQDCigC5uM/yEL XlTusq6Dft4tBRsO+LSOpsNh8++ddAHdm/Rtzi7kBOzxi7IRsVSPEi6MPU+cpf68bBoY g4OWkJlM8a2ERtZnI9RArW6Uqj0QZtpML1d6ARBo3r9r2wu0oyOuaxRH3JlIzu2VD9q5 OGtfB7EOiGjwswf7HbdbLnbVPPFcU7hodVomKWXVEEUlQB1Asn1m8HdjnCRQo78Byb4k c7YQ== X-Gm-Message-State: APjAAAUwhpaH1O60N1tozCi7A2FA5oPsENqrnZREVrsB/YRNdIXtOJzy +07W93VJ2cjWzIhNGhcTfXu2uGoP X-Google-Smtp-Source: APXvYqy8SgDt3elLjKHHKNemlUaLKFnQxN/0M9xNCZb3OHcTQABdboE6bONAzp+FCvgyhOklROM5zQ== X-Received: by 2002:a9d:10d:: with SMTP id 13mr73952108otu.149.1577759878321; Mon, 30 Dec 2019 18:37:58 -0800 (PST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com. [209.85.210.47]) by smtp.gmail.com with ESMTPSA id m19sm16454910otn.47.2019.12.30.18.37.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2019 18:37:57 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id p8so12192745oth.10; Mon, 30 Dec 2019 18:37:57 -0800 (PST) X-Received: by 2002:a9d:6c92:: with SMTP id c18mr62339496otr.157.1577759877831; Mon, 30 Dec 2019 18:37:57 -0800 (PST) MIME-Version: 1.0 References: <201912302239.xBUMdTli021436@repo.freebsd.org> In-Reply-To: <201912302239.xBUMdTli021436@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 30 Dec 2019 18:37:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r356210 - head/sys/nfs To: Rick Macklem Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47mz476ngXz3HPJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2019 02:38:00 -0000 Hi Rick, One suggestion: On Mon, Dec 30, 2019 at 2:39 PM Rick Macklem wrote: > > Author: rmacklem > Date: Mon Dec 30 22:39:29 2019 > New Revision: 356210 > ... > --- head/sys/nfs/nfs_lock.c Mon Dec 30 22:05:57 2019 (r356209) > +++ head/sys/nfs/nfs_lock.c Mon Dec 30 22:39:29 2019 (r356210) > @@ -89,6 +89,8 @@ nfslock_open(struct cdev *dev, int oflags, int devtype > { > int error; > > + printf("WARNING: uses Giant and will be removed before FreeBSD 13\n" > + "\tuse the kernel NFSLOCKD/nfslockd.ko\n"); This could be 'gone_in(13, "uses Giant; replace with NFSLOCKD/nfslockd.ko");' Best, Conrad