From nobody Thu Feb 9 09:46:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PCBpl3WmPz3nRll for ; Thu, 9 Feb 2023 09:46:55 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PCBpl1RH3z4PMk; Thu, 9 Feb 2023 09:46:55 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675936015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bt1sGs5wSWv4pFF7f9l9do/OuWnpos1XQyiu1+tb7Wo=; b=e3cnGoJKSHXVH3jmYLY9F0VyjLGfmdHjVRbiLWBXOj4eLtd4fdIRvUHkNPe/QqiDfgmr5Y 882WCbjrEoT8MbmUdHRPJr8A+8HrOeqIdGhJt/SkAdS3CEI9OlE2N7c3lJUo/eFl8Alq8N Z08NlE/ra5QkesH52GZKfDxs2scLwOddAJsv3lFUFWqunVu5uSH4tfR0P/YFkJcBqip3qk nH5vdjvomzgeC0/OuImrtku8mWe7ditXcVPklm2rX+ulVOG1NKfT8yl9r6LiNEQDT+YiuV Coj9LqEdzGLFRoD4HWytJhyguvbz16YzkLvnouxjWaDO1sJAGeeIpD5s0nkGag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675936015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bt1sGs5wSWv4pFF7f9l9do/OuWnpos1XQyiu1+tb7Wo=; b=aMXWx/90qHdfeZecqwuH7yJ0naJIdTKb74MZGqcehMR+NKIUBGS33Y8deWsfJ73ByiSOgz jdZDI4bwuniZZSHtjzCmf2xsSyV63u+YQSh8GNucNlbdLivAIx/PpuFHVw8SJzws229O5p UwK0B3ngFfqwyoIgETb6+7vAICM/rYBU2Fg4wbnRVU34F6qWsGY9CAeAWgq3krbszfJINK HDY9S2L3Gg9eYhNFXshf2H1kprahiIy9FZHHVJuaheWNH8ld9XHNzBfz1MgAz6eNEqXN3v bH6teXQz/0mI29KMEEcWgmzaLf/DeKTNifSrm5S4WPZomFSjK2UwjEEP4KHuvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675936015; a=rsa-sha256; cv=none; b=ehuWLedk5IS9Tm6c/G+Caj4Vtx4+1SwGCxADqUB+CWfNKxuNI1L5HvlCV7XMVY1OZE8dIP gPMzHudxAdEKXo1u7k+eocWYcHkWq3ZYTY8wXbdztoqy2RkegtheF72SjKI8Q/ZVCM3piW e5Fw6KvMT0JXuuY8GCsINywpq6MabFHtRrQilJVYRxpJuQwG4bi6qNYRMOY3p5fBP0BLYb 2dzoiuFtBv8rOQWkDszI7N02jI+pQCjhg42GdqCle2QDOOOG5weaBnPNRpuewG0nhEIghi 1ltUu46WSqe8smp0CWzGHiBmAVNvcPb7nskB5mPMv7tP0OehiYLVd9YysuDT/Q== Received: from ltc.des.no (unknown [84.210.219.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PCBpk6nJRzKXb; Thu, 9 Feb 2023 09:46:54 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.no (Postfix, from userid 1001) id 29093B6AFA; Thu, 9 Feb 2023 10:46:49 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Alexander Leidinger Cc: dev-commits-src-all@freebsd.org Subject: Re: git: 0dfaefa97547 - main - depend-cleanup.sh: Simplify the logic, and clean bootstrap tools. In-Reply-To: <20230209083133.Horde.q3w2RmVjVzPwrvCq2u6yNUU@webmail.leidinger.net> (Alexander Leidinger's message of "Thu, 09 Feb 2023 08:31:33 +0100") References: <20230209083133.Horde.q3w2RmVjVzPwrvCq2u6yNUU@webmail.leidinger.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (berkeley-unix) Date: Thu, 09 Feb 2023 10:46:49 +0100 Message-ID: <86ttzvw4qe.fsf@ltc.des.no> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N Alexander Leidinger writes: > You change from "no fork+exec if the file doesn't exist" (due to "if" > and "[" being shell-builtins) to "always fork+exec". On fast machines > surely not an issue, on slow ones, it may make a difference (I have an > old amd64 machine at an ISP which takes days to do a buildworld with > -j2 due to not much memory, only 2 cores, old HDs, and other stuff > going on in parallel). Have you measured this? Because the whole point of clean_dep() is that the file it looks for nearly always exists. It's the grep we're not sure of. So checking if the file exists is nearly always a waste. > While the .depend.* namespace is surely controlled by us, would it > make sense to change the glob to ".{o,pico}" instead of ".*o" instead > to prevent unexpected surprises in the future? Our sh does not support the {} syntax. Besides, what would it change? What else would match .*o but not .{o,pico}? DES -- Dag-Erling Sm=C3=B8rgrav - des@des.no