From owner-svn-ports-head@FreeBSD.ORG Fri May 2 00:58:13 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8E1209C4; Fri, 2 May 2014 00:58:13 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1AAF4126A; Fri, 2 May 2014 00:58:13 +0000 (UTC) Received: from [192.168.2.1] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 30B7F11F946; Thu, 1 May 2014 20:21:50 -0400 (EDT) From: "Adam Weinberger" To: "Matthew D. Fuller" Subject: Re: svn commit: r352762 - in head: japanese/spamassassin japanese/spamassassin/files mail/spamassassin Date: Thu, 01 May 2014 20:21:48 -0400 Message-ID: In-Reply-To: <20140501221514.GC7138@over-yonder.net> References: <201405011701.s41H1IG7048542@svn.freebsd.org> <20140501221514.GC7138@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.7.2r4025) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 May 2014 00:58:13 -0000 On 1 May 2014, at 18:15, Matthew D. Fuller wrote: > On Thu, May 01, 2014 at 05:01:18PM +0000 I heard the voice of > Adam Weinberger, and lo! it spake thus: >> >> Also, stop the spamd service on deinstall if it's running. It >> creates zombie issues otherwise... I'm pretty sure this is the >> right thing to do. > > I'd disagree. The source of the problem is that the plist @unexec rm > -rf's the dir containing the pid file (and in fact, other things that > shouldn't be blown away, in some configs of mine). That should really > just flat not happen. You're totally right, that was absolutely not good behaviour. It no longer does that (it's a @dirrmtry now) so it should be a much better citizen. Let me know if it's still removing things that it shouldn't be! # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org