From owner-svn-src-user@FreeBSD.ORG Thu Mar 11 22:13:17 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 618301065672; Thu, 11 Mar 2010 22:13:17 +0000 (UTC) (envelope-from jmallett@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 51EE48FC1B; Thu, 11 Mar 2010 22:13:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2BMDHNd087714; Thu, 11 Mar 2010 22:13:17 GMT (envelope-from jmallett@svn.freebsd.org) Received: (from jmallett@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2BMDHEp087711; Thu, 11 Mar 2010 22:13:17 GMT (envelope-from jmallett@svn.freebsd.org) Message-Id: <201003112213.o2BMDHEp087711@svn.freebsd.org> From: Juli Mallett Date: Thu, 11 Mar 2010 22:13:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r205045 - user/jmallett/octeon/sys/mips/cavium/dev/rgmii X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 22:13:17 -0000 Author: jmallett Date: Thu Mar 11 22:13:16 2010 New Revision: 205045 URL: http://svn.freebsd.org/changeset/base/205045 Log: Remove a silly comment, remove gratuitous braces. Suggested by: imp Modified: user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Modified: user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c ============================================================================== --- user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Thu Mar 11 22:11:24 2010 (r205044) +++ user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Thu Mar 11 22:13:16 2010 (r205045) @@ -1768,12 +1768,6 @@ static void octeon_rgmx_init (void *xsc struct rgmx_softc_dev *sc = xsc; octeon_rgmx_rxx_rx_inbnd_t link_status; - /* - * Called mostly from ifnet interface ifp->if_init(); - * I think we can anchor most of our iniialization here and - * not do it in different places from driver_attach(). - */ - /* Enable interrupts. */ /* For RGMX they are already enabled earlier */ @@ -1801,11 +1795,10 @@ static void octeon_rgmx_init (void *xsc */ link_status.word64 = sc->link_status; - if (link_status.bits.status) { + if (link_status.bits.status) if_link_state_change(sc->ifp, LINK_STATE_UP); - } else { + else if_link_state_change(sc->ifp, LINK_STATE_DOWN); - } RGMX_UNLOCK(sc); }