From owner-freebsd-usb@freebsd.org Tue Sep 4 14:29:25 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4344FFF0E2D for ; Tue, 4 Sep 2018 14:29:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D5A3671D5E for ; Tue, 4 Sep 2018 14:29:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 95D55FF0E2B; Tue, 4 Sep 2018 14:29:24 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84A43FF0E2A for ; Tue, 4 Sep 2018 14:29:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2563A71D5A for ; Tue, 4 Sep 2018 14:29:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7C84A53F5 for ; Tue, 4 Sep 2018 14:29:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w84ETNHP022303 for ; Tue, 4 Sep 2018 14:29:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w84ETNPP022302 for usb@FreeBSD.org; Tue, 4 Sep 2018 14:29:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 188829] [atp] atp fails on Macbook Pro 4.1 [regression] Date: Tue, 04 Sep 2018 14:29:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jwb@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 14:29:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D188829 --- Comment #5 from Jason W. Bacon --- Created attachment 196858 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D196858&action= =3Dedit Unified diff The author of the atp driver pointed me to this patch some time ago and I w= as surprised to see that the problem still exists in 11.1-RELEASE. It has to do with recalibrating the touchpad as temperature rises. The patch still applies cleanly and solves the problem on my MacBook Pro. >From dmidecode: System Information Manufacturer: Apple Computer, Inc. Product Name: MacBookPro2,2 Version: 1.0 There's another small problem now, though. "make install" places the modul= e in /boot/modules, and kldload still grabs the old one from /boot/kernel. Here's what I do in total to make this problem go away: cd /usr/src/sys/dev/usb/input fetch http://acadix.biz/atp.patch if [ ! -e atp.c.save ]; then cp atp.c atp.c.save fi if [ ! -e atp.c.orig ]; then patch < atp.patch fi if [ ! -e /boot/kernel/atp.ko.save ]; then cp /boot/kernel/atp.ko /boot/kernel/atp.ko.save fi cd /usr/src/sys/modules/usb/atp make kldunload atp make install cp /boot/modules/atp.ko /boot/kernel # protect filesystem in case kld[un]load causes problems. Hasn't happened f= or # me with atp, but it's a general habit based on a few bad experiences. sync kldunload atp kldload atp --=20 You are receiving this mail because: You are the assignee for the bug.=