From owner-freebsd-hackers  Tue Jan 13 18:53:45 1998
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id SAA24257
          for hackers-outgoing; Tue, 13 Jan 1998 18:53:45 -0800 (PST)
          (envelope-from owner-freebsd-hackers@FreeBSD.ORG)
Received: from etinc.com ([207.252.1.2])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA12240
          for <hackers@freebsd.org>; Tue, 13 Jan 1998 17:14:35 -0800 (PST)
          (envelope-from dennis@etinc.com)
Received: from dbsys.etinc.com (dbsys.etinc.com [207.252.1.18]) by etinc.com (8.8.7/8.6.9) with SMTP id SAA11472; Tue, 13 Jan 1998 18:04:44 -0500 (EST)
Message-Id: <3.0.32.19980113180616.00793af0@etinc.com>
X-Sender: dennis@etinc.com
X-Mailer: Windows Eudora Pro Version 3.0 (32)
Date: Tue, 13 Jan 1998 18:06:21 -0500
To: Eivind Eklund <eivind@yes.no>
From: dennis <dennis@etinc.com>
Subject: Re: FreeBSD Netcards
Cc: Eivind Eklund <perhaps@yes.no>, Tom <tom@sdf.com>,
        Jamie Bowden <jamie@itribe.net>, hackers@FreeBSD.ORG
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk

At 02:27 AM 1/13/98 +0100, Eivind Eklund wrote:
>On Mon, Jan 12, 1998 at 08:17:15PM -0500, dennis wrote:
>> At 10:38 PM 1/12/98 +0100, Eivind Eklund wrote:
>>> dennis <dennis@etinc.com> writes:
>>>> Just look in raw_usrreq(). the default case is a panic. 
>>> 
>>> Fixed in revision 1.12 as of April 27, 1997.
>>> 
>>> Do you have anything else?  (I don't think any of us want panic()s to
>>> occur for userland errors, though I think they often are the correct
>>> path for a kernel error.)
>> 
>> 2.2.5-RELEASE is shipped with v1.8 which is dated 3/11/96, so
>> something is amiss. If it takes a year for these fixes to make it
>> into a release it doesnt do anyone any good...
>
>Well, this was fixed as a part of a major rewrite of that part of the
>code.  The patch that fixes this is actually twice as large as the
>raw_usrreq file.  I also _think_ it links in with more modifications
>elsewhere, but I haven't looked to closely - it came in in a
>mega-commit, at least.
>
>At least be happy it is fixed in 3.0 :-)
>
>Do you have any other cases of panic() being used incorrectly?

yeah..go into each director do a "grep panic *.c" ...about half of them
are unnecessary.

Dennis