From owner-freebsd-hackers@FreeBSD.ORG Fri Mar 5 19:59:13 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3BE4106566B for ; Fri, 5 Mar 2010 19:59:13 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-exrelay2.uni-muenster.de (ZIVM-EXRELAY2.UNI-MUENSTER.DE [128.176.192.15]) by mx1.freebsd.org (Postfix) with ESMTP id 341ED8FC1C for ; Fri, 5 Mar 2010 19:59:12 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.49,588,1262559600"; d="scan'208";a="238412255" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER01.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay2.uni-muenster.de with ESMTP; 05 Mar 2010 20:59:11 +0100 Received: by ZIVMAILUSER01.UNI-MUENSTER.DE (Postfix, from userid 149459) id 719E81B0768; Fri, 5 Mar 2010 20:59:11 +0100 (CET) Date: Fri, 05 Mar 2010 20:59:10 +0100 (CET) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: Message-ID: In-Reply-To: <4B915D44.5000402@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org Subject: Re: tiny lib/libkvm/kvm_proc.c correction X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2010 19:59:13 -0000 Xin LI schrieb am 2010-03-05: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > On 2010/03/05 11:26, Alexander Best wrote: > > hi there. does this look right? > Not to me, the value is not to be used this way and the comments > above > the code explained the same thing. > I think we should use cputick2usec but it's not available to userland > (one have to copy cpu_tick_frequency and friends). damn you're right. i completely overlooked that comment. would it be worth making cputick2usec available to userland? is kvm_proc.c the only candidate in need of converting cpu ticks to usecs? alex > Cheers, > - -- > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! Live free or die > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.14 (FreeBSD) > iQEcBAEBAgAGBQJLkV1EAAoJEATO+BI/yjfBvhcH/3LD5SOscV7wmzVazQtvhOpd > C4xhRlnlZEniI8qrKP1L55Q9eTntxzcWZPhmImb5UspSX6a5aRsWHrySlD82Vjgy > u/n/tz/YbhGV4QasmRxrXOF8wrPh3ie0W6912hFHmMZ6shgfm9GvoAlltnCcnnNp > O330syWOVqf/q+9y5FOXIschYPs8HmAP7Fy5pMragpzdmpg5uCBdKXbekvfqiscN > qPOOrzzyvkmXS3rKBY5vnRHqJTaOveSuE6KEjN1x/D0ZJ71kY6tLwZCCMc9wNlJB > Dv/U3ZPo4lUki2tZTOi9bo4KEkLR/3zrFQ5VeaDhYI/FHCQTFB1jhNoahU2WlB0= > =JOn5 > -----END PGP SIGNATURE-----