From owner-freebsd-bugs@FreeBSD.ORG  Tue Nov  4 05:00:45 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CB8CD16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  4 Nov 2003 05:00:45 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 525CE43F93
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  4 Nov 2003 05:00:45 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hA4D0hFY066692
	for <freebsd-bugs@freefall.freebsd.org>;
	Tue, 4 Nov 2003 05:00:43 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hA4D0gH6066690;
	Tue, 4 Nov 2003 05:00:42 -0800 (PST)
	(envelope-from gnats)
Date: Tue, 4 Nov 2003 05:00:42 -0800 (PST)
Message-Id: <200311041300.hA4D0gH6066690@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ian Dowse <iedowse@maths.tcd.ie>
Subject: Re: bin/58912: dump fails on big directories with nodump flag set 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Ian Dowse <iedowse@maths.tcd.ie>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2003 13:00:45 -0000

The following reply was made to PR bin/58912; it has been noted by GNATS.

From: Ian Dowse <iedowse@maths.tcd.ie>
To: vpaepcke@dssgmbh.de
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/58912: dump fails on big directories with nodump flag set 
Date: Tue, 04 Nov 2003 12:49:48 +0000

 In message <200311040922.hA49MOil001182@uxpae.incore>, vpaepcke@dssgmbh.de writ
 es:
 >>Fix:
 >	There is a bug in /usr/src/sbin/dump/traverse.c:
 >	The inode buffer referenced by dp may change during the
 >	the call to searchdir() and may not be used thereafter.
 >	The inode buffer di containing a copy of the original one 
 >	must be used instead.
 
 Thanks for tracking this down! BTW, there seems to be another use
 of `dp' a few lines later that suffers from the same problem. I'll
 fix both shortly.
 
 Ian