From owner-freebsd-testing@FreeBSD.ORG Fri Mar 14 13:11:55 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 531723AA; Fri, 14 Mar 2014 13:11:55 +0000 (UTC) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2087C8F6; Fri, 14 Mar 2014 13:11:55 +0000 (UTC) Received: by mail-pa0-f46.google.com with SMTP id kp14so2630042pab.33 for ; Fri, 14 Mar 2014 06:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=rwrbI+q5w9bJD4LTAkw3x9lHMYL6pYt7fUH2HpRESQA=; b=T9zinvQVBuPieLpPyla8AjP97Ii2ZvNruWA/vsspy5ytNAN1B5HgtOa7aXi7Qcsyfz BtsLBl+SjJplKmpznx1DXxk+ccVyivS0cgTJUZuJIFjoa3QOV8FUfoiXCeOF+U707DoX 8U8gFTfut9miBaOFfvbLT1nmKFmlre+XtkR8K3EgEortNsFaeUaVV+203vOJKHgSHdwX r2cntNP8u7AmcKv7syah3OB6rg897XwaJIp46ohyWSfkkTWAg0bNxf45EoAYvsz2qAzf gdzCVpjlj7Pehq2o6FrASkcwaO21ew1eSEUbgQQkMrvgjjW+fNUF6WFe0RA0JzReFti/ DIXA== X-Received: by 10.68.28.69 with SMTP id z5mr8974261pbg.121.1394802714769; Fri, 14 Mar 2014 06:11:54 -0700 (PDT) Received: from [192.168.20.11] (c-24-17-226-153.hsd1.wa.comcast.net. [24.17.226.153]) by mx.google.com with ESMTPSA id db3sm16624441pbb.10.2014.03.14.06.11.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Mar 2014 06:11:53 -0700 (PDT) References: <423AB61A-6099-40F1-8931-B5339FFAEB65@gmail.com> Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <769C5BD0-D803-46EB-AD18-A3031AC2036E@gmail.com> X-Mailer: iPhone Mail (11B651) From: Garrett Cooper Subject: Re: Where to put test cases for stuff in /etc? Date: Fri, 14 Mar 2014 06:11:52 -0700 To: Julio Merino Cc: "freebsd-testing@freebsd.org" , "asomers@gmail.com" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2014 13:11:55 -0000 > On Mar 14, 2014, at 0:53, Julio Merino wrote: >=20 >> On Fri, Mar 14, 2014 at 5:40 AM, Garrett Cooper w= rote: >>=20 >>> On Mar 13, 2014, at 13:23, asomers@gmail.com wrote: >>>=20 >>> I occasionally make changes to /etc/rc.subr and /etc/rc.d/*. Where >>> can I write ATF test cases for those files? Should I create >>> etc/tests/rc.subr_test.sh and etc/rc.d/tests/routing_test.sh ? >=20 > Tests for these would be awesome. >=20 >> Putting it under tests/etc would be a better idea for now. The build s= ystem under etc/ is a bit of a mess... >=20 > What's the problem with putting tests in etc/tests/ and what would it > take to fix that? You'd need to create ad hoc make recipes that handled WITH_TEST properly, or= enhance the Makefiles to use bsd.*.mk. Cheers, -Garrett=