From owner-freebsd-current@FreeBSD.ORG Sat Feb 1 00:06:57 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5CB8BDE8 for ; Sat, 1 Feb 2014 00:06:57 +0000 (UTC) Received: from mail-yk0-x231.google.com (mail-yk0-x231.google.com [IPv6:2607:f8b0:4002:c07::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 12390175A for ; Sat, 1 Feb 2014 00:06:57 +0000 (UTC) Received: by mail-yk0-f177.google.com with SMTP id 19so27897630ykq.8 for ; Fri, 31 Jan 2014 16:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=8jXNOG9Z9Ck/ROhW1inyOmiqziJWs/ZA2zVj8tM75FI=; b=eA+zDtAZn4sxO6oOcl6BoJrlAHU46rzEYfWUvmnPqJx1uXXr6LayYMGef4/RkSZDa2 Ch6ySqYZNhEb6JXqKxGki2UiqEBj5d9eD7kgCHTfO+o1Mp9zJQ1c4ZBZS9h3lJYQsTce 6hYOPH8rndKOrTk/2O1fMRHN708gKrgjijbClFGV6h9FqR6J9cNwUuLFTraJ6fgJqa6d NUWVO7CDSI/RhYTHv3qJiJLYGIn1ywbmKqNbdDqeXiNQiJHzW3fnd/162nxR9q2Y/FeV QEgO9XAv+lEMS8bTv3AGzTB5Sj9e6rDMnYX/UaaznY6SG1c/flBvG+s6DJobbOq5hew0 JYwQ== X-Received: by 10.236.86.141 with SMTP id w13mr21521498yhe.41.1391213216210; Fri, 31 Jan 2014 16:06:56 -0800 (PST) Received: from [192.168.137.178] ([201.55.128.238]) by mx.google.com with ESMTPSA id m9sm39199938yha.2.2014.01.31.16.06.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 Jan 2014 16:06:55 -0800 (PST) Sender: =?UTF-8?Q?Danilo_Eg=C3=AAa_Gondolfo?= Message-ID: <52EC3B6C.20202@freebsd.org> Date: Fri, 31 Jan 2014 22:10:20 -0200 From: "Danilo E. Gondolfo" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Apple Trackpad driver References: <52E8DDA3.3070301@bitfrost.no> <52E9F546.9090005@bitfrost.no> <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org> <52EC2889.9020107@bitfrost.no> <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> In-Reply-To: <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2014 00:06:57 -0000 On 01/31/14 21:45, 黄文辉@Gmail wrote: > Hi Hans, > Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can add a notice about that. Table and some structure bt_data, tp_finger from Linux, I only wrote wsp_intr_callback base on usbdump, all other part should be belong to Hans. > > Cheers, > > Huang Wen Hui > >> 在 2014年2月1日，6:49，Hans Petter Selasky 写道： >> >>> On 01/31/14 21:30, Danilo E. Gondolfo wrote: >>>> On 01/31/14 05:16, Hans Petter Selasky wrote: >>>>> On 01/31/14 02:46, Huang Wen Hui wrote: >>>>> Hi Hans, >>>>> >>>>> pos_x[] is not non-inialized, it may be previous pos_x, it is still >>>>> ok for >>>>> getting dx. >>>>> "n" var is trying to reduce "untouch" sensor data for post >>>>> proccessing. I >>>>> attach a new patch >>>>> may be more clear, also fixed unexpected movement when button status or >>>>> ntouch changing. >>>>> >>>>> Cheers, >>>>> >>>>> Huang Wen Hui >>>> Hi, >>>> >>>> http://svnweb.freebsd.org/changeset/base/261315 >>>> >>>> --HPS >>> Good work! >>> >>> I noticed that your driver is based on the Linux driver [1] and some >>> pieces of code are copied, are you sure that we won't have any problems >>> with license? >>> >>> These changes can be (should be) merged in the driver atp(4), no? >>> >>> Danilo. >>> >>> >>> [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c >> Hi, >> >> It looks to me like some tables have been copied. We probably should add a notice about that. The rest of the code looks OK to me. >> >> Huang, any comments? >> >> --HPS >> > Hello, And what about keeping these two driver? (atp and wsp) Both has the same purpose. Wouldn't be better merge the new code on atp? On freebsd-drivers@ the author of the atp driver started a thread about this [1]. Danilo. [1] - http://lists.freebsd.org/pipermail/freebsd-drivers/2014-January/001659.html