From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 2 20:00:11 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22E1D10656F4 for ; Mon, 2 Mar 2009 20:00:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E8AF68FC33 for ; Mon, 2 Mar 2009 20:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n22K0Aa8066136 for ; Mon, 2 Mar 2009 20:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n22K0AEq066135; Mon, 2 Mar 2009 20:00:10 GMT (envelope-from gnats) Resent-Date: Mon, 2 Mar 2009 20:00:10 GMT Resent-Message-Id: <200903022000.n22K0AEq066135@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jan Henrik Sylvester Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96F5110656FB for ; Mon, 2 Mar 2009 19:51:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 855208FC17 for ; Mon, 2 Mar 2009 19:51:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n22JpFAM001340 for ; Mon, 2 Mar 2009 19:51:15 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n22JpEAU001338; Mon, 2 Mar 2009 19:51:14 GMT (envelope-from nobody) Message-Id: <200903021951.n22JpEAU001338@www.freebsd.org> Date: Mon, 2 Mar 2009 19:51:14 GMT From: Jan Henrik Sylvester To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/132267: multimedia/kaffeine DVB-T is broken, fix included X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2009 20:00:16 -0000 >Number: 132267 >Category: ports >Synopsis: multimedia/kaffeine DVB-T is broken, fix included >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 02 20:00:10 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Jan Henrik Sylvester >Release: 7.1-RELEASE-p3 i386 >Organization: >Environment: >Description: Raaf confirmed that DVB-T is broken for some time last February: http://lists.freebsd.org/pipermail/freebsd-multimedia/2008-February/008092.html Now Tim Borgeaud introduced a new DVB-T device: http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-March/009816.html There he put a new version of patch-dvbsection.cpp that fixes the problem for the new DVB device. I can confirm that the new patch also fixes the problem for the Freecom device that is covered by Raaf's driver. Thus, the new patch should be included with the port. >How-To-Repeat: - attach a Freecom DVB-T device with Raaf's driver - try to scan DVB-T channels - observe Kaffeine crashing >Fix: The patch by Tim Borgeaud works. It is from: http://www.tangobravo.co.uk/v4l-compat/ Patch attached with submission follows: diff -u multimedia/kaffeine/files/patch-dvbsection.cpp.orig multimedia/kaffeine/files/patch-dvbsection.cpp --- multimedia/kaffeine/files/patch-dvbsection.cpp.orig 2008-01-31 15:47:31.000000000 +0100 +++ multimedia/kaffeine/files/patch-dvbsection.cpp 2009-03-02 20:27:11.000000000 +0100 @@ -1,6 +1,6 @@ --- kaffeine/src/input/dvb/plugins/epg/kaffeinedvbsection.cpp.orig 2008-01-30 22:22:36.000000000 +0100 +++ kaffeine/src/input/dvb/plugins/epg/kaffeinedvbsection.cpp 2008-01-30 22:26:23.000000000 +0100 -@@ -134,7 +134,8 @@ +@@ -134,13 +134,14 @@ bool KaffeineDVBsection::doIconv( QCString &s, QCString table, char *buffer, int buflen ) { size_t inSize, outSize=buflen; @@ -10,6 +10,13 @@ iconv_t cd; inSize = s.length(); + if ( inSize<1 ) + return false; +- cd = iconv_open( "UTF8", table ); ++ cd = iconv_open( "UTF-8", table ); + inBuf = s.data(); + outBuf = buffer; + outBuf[0] = 0; @@ -230,7 +231,8 @@ char c[4]; QString s; >Release-Note: >Audit-Trail: >Unformatted: