From owner-freebsd-bugs@freebsd.org Sun Jan 8 16:53:56 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E0A7CA5DAF for ; Sun, 8 Jan 2017 16:53:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08B6A1051 for ; Sun, 8 Jan 2017 16:53:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v08Grt3e036763 for ; Sun, 8 Jan 2017 16:53:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 215874] [patch] [icmp] [mbuf_tags] teach icmp_error() optionally keep original packet's mbuf_tags Date: Sun, 08 Jan 2017 16:53:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ports@grosbein.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2017 16:53:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215874 Bug ID: 215874 Summary: [patch] [icmp] [mbuf_tags] teach icmp_error() optionally keep original packet's mbuf_tags Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: ports@grosbein.net Keywords: patch Created attachment 178624 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D178624&action= =3Dedit introduce new sysctl net.inet.icmp.error_keeptags Currently, icmp_error() function copies FIB number into generated ICMP resp= onse from original packet but not mbuf_tags(9) chain. This prevents us from easi= ly matching of ICMP packets corresponding to tagged original ones by means of ipfw(8). For example, ICMP "time-exceeded in-transit" packets (usually generated in response to traceroute probes) lose tags attached to original packets. Atta= ched simble patch introduces new sysctl net.inet.icmp.error_keeptags with default value 0 corresponding to current behaviour to avoid extra overhead. sysctl net.inet.icmp.error_keeptags=3D1 makes icmp_error() copy mbuf_tags f= rom original packet to generated ICMP response. --=20 You are receiving this mail because: You are the assignee for the bug.=