From owner-freebsd-current@freebsd.org Wed Jun 7 19:12:51 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51E96D7B964 for ; Wed, 7 Jun 2017 19:12:51 +0000 (UTC) (envelope-from jpaetzel@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 27D997FD86 for ; Wed, 7 Jun 2017 19:12:50 +0000 (UTC) (envelope-from jpaetzel@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 86CE820CCC for ; Wed, 7 Jun 2017 15:12:44 -0400 (EDT) Received: from web1 ([10.202.2.211]) by compute2.internal (MEProxy); Wed, 07 Jun 2017 15:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KJGC+e KzQbRzj+CUfzGjs8II+U9MfZXWRJqnf9oX0rQ=; b=LKNa6Mn6zi+meP9NBkt+sD q+5xaM1/41Oa6kM5CMrm41o8Bq0fLuT64/hv3gnog2hsdcdp888TLvYPXaOualYO ppPXa1YTOlEsEU1mq4E+dv+upSSR+pS6hwZNROqzZrVGBcQ/zJ+CXMb9My5vSSvu LPiO1IQ4T+kj0zyb+AAIoqgvyqXFt+W1joelfUy9yc92gqqTUu23eRO1SWWsm9jd R3wMqvc4pqyUsAtkCAlwzOUZYE2hnrIO1/HAD/wLmaHYjIRcMG943eU0iRvGR+vo fi3C9ketlCqvRM3BGGoAdw1bp+uFi8mej+oFka+XXQHpanIGJqnrmNN0TjjaLjKA == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 68F9D946C4; Wed, 7 Jun 2017 15:12:44 -0400 (EDT) Message-Id: <1496862764.923234.1002086344.272B2D5D@webmail.messagingengine.com> From: Josh Paetzel To: freebsd-current@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-72fcb609 References: <20170606100034.GA4245@c720-r314251> <20170606123738.GA5213@c720-r314251> <20170607123531.GA4867@c720-r314251> <20170607172234.GA3972@c720-r314251> <20170607192915.28088b71@thor.intern.walstatt.dynvpn.de> Date: Wed, 07 Jun 2017 14:12:44 -0500 In-Reply-To: <20170607192915.28088b71@thor.intern.walstatt.dynvpn.de> Subject: Re: mount_smbfs gives error when stored crypted pw is used X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 19:12:51 -0000 On Wed, Jun 7, 2017, at 12:29 PM, O. Hartmann wrote: > Am Wed, 7 Jun 2017 19:22:34 +0200 > Matthias Apitz schrieb: >=20 > > El d=C3=ADa mi=C3=A9rcoles, junio 07, 2017 a las 02:35:31p. m. +0200, M= atthias Apitz escribi=C3=B3: > >=20 > > > I have located the bug in /usr/src/contrib/smbfs/lib/smb/subr.c=20 > > >=20 > > > The printf(3C) calls have been added for debugging; the bug is the > > > addition of 13 after crypting every char which let the mask used in ^= operation > > > exceeding 256, i.e. more than one byte, if the string to be crypted i= s long > > > enough. The two lines added: > > >=20 > > > if (pos > 256) > > > pos =3D pos-256; > > >=20 > > > fixes this issue and the crypting/decypting works fine; see below; > > >=20 > > > I'll later file a PR and propose the patch;=20=20 > >=20 > > The PR was already made in 2009: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D132302 has a patch = attached (nearly > > the same solution as I have found), but was never ci'ed :-( > >=20 > > matthias > >=20 > >=20 >=20 > Wow ... that is, simply ... not very good! :-( >=20 > High quality! >=20 > --=20 > O. Hartmann >=20 > Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr > Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Ab= s. 4 > BDSG). > Email had 1 attachment: > + Attachment2 > 1k (application/pgp-signature) I've taken the bug and am testing it now. Should have it committed by this evening. With some luck we can get it in to 11.1 --=20 Thanks, Josh Paetzel