From nobody Sun Feb 1 19:27:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f40CG3n2dz6QTNY for ; Sun, 01 Feb 2026 19:28:10 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f40CF02D8z45dS for ; Sun, 01 Feb 2026 19:28:09 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=6yearold@gmail.com Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79492a2a57bso35411097b3.2 for ; Sun, 01 Feb 2026 11:28:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769974088; x=1770578888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q+vVUfZiBpDqnIzq6HtFVDcN9V4ZYZnI4hl6ZlUfE40=; b=SLoWdCAUQfO8VopL4x9OcxAR5vtxH9AsXDbQec2+odJ2y6I4GroRwD1/xvbugOm4sF jcUhnIWeEypjFfmI9cEqSZPqc6rblCLSs9HnfacXHHh/rfuvyoh9VaeG4AdD8PEG/pg3 LSUeemIg8dcx93eTsuXBHpX8sbcVDMnoiEmB6RgVJ/ewIqw21pcdyOuaWU9zmDywGyDW nrsahVa6IA1nIgtIjhFlrb9F+Rf4TtkzJUelDHVo0iemZPIi9n+/X5pDWBMkhY7bTX6X +AoJqpe1AyrogbRKWJzjB5yC4XTPgy3EUnDD+8FEVE2NdPsH46J7zckgJ3Ap2zI3bllf 2nRQ== X-Forwarded-Encrypted: i=1; AJvYcCW7d8UXdppsIxPeVrIFU2Co+w+auq6tr3+DRzQDoQQ69S5pSmM+NWEKwQJkQWi8ETsV/et6tOjFOkgcSqY7RJgNP0bi@freebsd.org X-Gm-Message-State: AOJu0YyGqDlh3R46Rjc6NIdj895sqXhCBRCvAsgQtRuAVXNQxg4cQXUZ EuISKR04KSCW72cddC0iK8qlddPVchmLuDumj6iS93/Z5b9qdLUXBh2vbSoCww== X-Gm-Gg: AZuq6aI7Y5qqbMq+uV88lGIyGyNeMNY8I/0T9E5iNl/Fw75yVcHQtNq3Eif/WtnuyKB /5lPmMmRpbdzNaZ1iCDuEto4oTJ2Wj2Dw0AoqVIExjdVbzI+UbYPFKw/JpCHJx96hoWgGP6RfKw gVBVP7JazqgqnqzO8ue06/1AYhdOpYheqw5hHagUG7L+4GdmWq3468TjjCicbvztAhfPGGWtd71 mqBFzjrlOOBhqe7ahegJMyhiVSxFRrc/wwThdaOGOXxI7otsDziTBIDUQ4Gkv0gYU6Scf8KpNBS FL48acRl50sE2B94IDTUFdNlyDAp37SDKrjXwDP/pzddchWtSkGjlt3/0qG/IIDvHF33H5H++fE dEvIyY/XJAqwjPdER5I+o0N/lXiZJU+uv/Erdhc/q4BO27lYqrzTKOsC/rrrJ+FHDABGZ4pTbF/ cuHajvSBllXLmhBfW5OHdMsB3fj5oRu+sI2f/bLhh67ZLuFxPxuJHMLh+aBatOU7JyR+ARQW59C UJk9LNe6kvTqOSxvxd7BH3FyvQ8WiQA5PI1y3YuZ8c47uJUYxxqfHX7m+abxLCp6QHrIjI= X-Received: by 2002:a05:690c:5996:b0:794:8055:7f98 with SMTP id 00721157ae682-7949e000ae8mr65512197b3.55.1769974087824; Sun, 01 Feb 2026 11:28:07 -0800 (PST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79482766c5dsm67793907b3.12.2026.02.01.11.28.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Feb 2026 11:28:07 -0800 (PST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-79496f0ea3fso29668377b3.0 for ; Sun, 01 Feb 2026 11:28:07 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVg3csCFVTXBK15Kg2+y4KwLKhaxP3WMC8icmn9JFC/UdjzlZADHkqaIcgw0VN94oo8ChBNo2TG6UKqqY9aaQM7ZThX@freebsd.org X-Received: by 2002:a05:690c:84d:b0:794:7131:3dc3 with SMTP id 00721157ae682-7949df9bc20mr56288667b3.41.1769974086949; Sun, 01 Feb 2026 11:28:06 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <697499a8.335a0.2e12eda1@gitrepo.freebsd.org> In-Reply-To: From: Gleb Popov Date: Sun, 1 Feb 2026 22:27:41 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: AZwV_Qg_xwXKX9aVs8JMQiZ2NQWJKcODdaHiykXihQ8rd0ykkgq8IRG36Z2t42A Message-ID: Subject: Re: git: 10037d0978f8 - main - fusefs: Implement support for the auto_unmount option kernel-side To: Konstantin Belousov , Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.85 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.985]; NEURAL_HAM_MEDIUM(-0.97)[-0.968]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.182:from,209.85.128.177:received]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MISSING_XM_UA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.182:from]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4f40CF02D8z45dS X-Spamd-Bar: -- On Sun, Jan 25, 2026 at 10:39=E2=80=AFPM Konstantin Belousov wrote: > > > > + vfs_ref(fdata->mp); > Don't you need to take the reference when the fdata is created and mp mem= ber > is initialized, and not here? > > What guarantees that the mp is still ours? > In fact, I think that you should use vfs_busy() and not vfs_ref(), > since what prevents mp from being unmounted under us? Using vfs_busy() before dounmount() results in a soft hang: - vfs_busy increments mp->mnt_lockref in https://github.com/freebsd/freebsd-src/blob/98bdf63f6e94be42a1787de73608de1= 5bcb3419a/sys/kern/vfs_subr.c#L929 - dounmount spins until mp->mnt_lockref becomes 0 in https://github.com/freebsd/freebsd-src/blob/98bdf63f6e94be42a1787de73608de1= 5bcb3419a/sys/kern/vfs_mount.c#L2318-L2322 This results in a FUSE process to hang in the "mount drain" state.