From owner-svn-src-stable@freebsd.org Mon Dec 28 03:36:46 2015 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FE31A4DF55; Mon, 28 Dec 2015 03:36:46 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-qg0-x235.google.com (mail-qg0-x235.google.com [IPv6:2607:f8b0:400d:c04::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 013011807; Mon, 28 Dec 2015 03:36:46 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-qg0-x235.google.com with SMTP id e32so48859709qgf.3; Sun, 27 Dec 2015 19:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yd+PvmQ1RImY4hKImjC0X/LWJWJOx8a6utP0PjdQzhk=; b=nMv08CWXqztApw86NXOVLyJMkDYfE0MxA/pek/Y7/0PjugcR+WhM7vV8ViD9yqTYFf CcaVdRNEB47Q0MkBq4BEFPohiu+1T/aHidJqemmJTtvjDnin8S2WsZf++m40Ez4N41uX 7DNP6Yp5yGkSLmfIhZa558xGY63kUwB9E1SbLzZmSK24ZqEw9W4H/gxKgtEvoL3XsfZD qs90UNegr/RauNA9IBOyZ+4kPJ0xxX4yBgcR0P3lZJG5poDTTOSdsrcKln81ib2elqLn ynEcA8VPYWGkU7jFK2wSgYBYnPTWJMsr4+ElpGDA6/txZT2s4SOzmrHqUbk7SqiShSSl F3eQ== X-Received: by 10.141.28.149 with SMTP id f143mr71321414qhe.66.1451273804830; Sun, 27 Dec 2015 19:36:44 -0800 (PST) Received: from [172.16.0.133] (c-174-59-104-177.hsd1.pa.comcast.net. [174.59.104.177]) by smtp.gmail.com with ESMTPSA id p17sm26430122qhb.34.2015.12.27.19.36.44 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 27 Dec 2015 19:36:44 -0800 (PST) Sender: Patrick Kelsey Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r292823 - in stable/10/sys: conf netinet From: Patrick Kelsey X-Mailer: iPhone Mail (13C75) In-Reply-To: <5680A991.5040301@freebsd.org> Date: Sun, 27 Dec 2015 22:36:43 -0500 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <0087B045-F70E-4CF5-A1B7-5B421926BB5A@freebsd.org> References: <201512280243.tBS2hD7X008202@repo.freebsd.org> <5680A574.9050002@freebsd.org> <5680A991.5040301@freebsd.org> To: Andrey Chernov X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 03:36:46 -0000 > On Dec 27, 2015, at 10:16 PM, Andrey Chernov wrote: >=20 >> On 28.12.2015 5:59, Andrey Chernov wrote: >>> On 28.12.2015 5:43, Patrick Kelsey wrote: >>> Author: pkelsey >>> Date: Mon Dec 28 02:43:12 2015 >>> New Revision: 292823 >>> URL: https://svnweb.freebsd.org/changeset/base/292823 >>>=20 >>> Log: >>> MFC r292706: >>>=20 >>> Implementation of server-side TCP Fast Open (TFO) [RFC7413]. >>>=20 >>> TFO is disabled by default in the kernel build. See the top comment >>> in sys/netinet/tcp_fastopen.c for implementation particulars. >>=20 >> Why it is disabled by default? Do we need some rc.conf knobs to not deal >> directly with it, like tcp_extensions? OMG, why it is kernel config and >> not boot-time sysctl? >=20 > BTW, TCP_RFC7413_MAX_KEYS currently unused and I have no clues what it > supposed to be. I can't find it in the phabric patch at all. >=20 Look at line 127 in tcp_fastopen.c. Also, read the top comment in tcp_fasto= pen.c. Phabricator is buggy and unreliable, and using it as a primary reference to t= he code will let you down as it has let me down, repeatedly. For example, i= t will not show you the contents of entirely new files unless you manually u= pload them - I believe this what is currently affecting your viewpoint. -Patrick=