From owner-cvs-src-old@FreeBSD.ORG Fri Oct 23 15:15:17 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A59E110656DB for ; Fri, 23 Oct 2009 15:15:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 923E98FC16 for ; Fri, 23 Oct 2009 15:15:17 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n9NFFHBm020744 for ; Fri, 23 Oct 2009 15:15:17 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n9NFFHas020743 for cvs-src-old@freebsd.org; Fri, 23 Oct 2009 15:15:17 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <200910231515.n9NFFHas020743@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Fri, 23 Oct 2009 15:14:54 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_exec.c kern_ktrace.c subr_bus.c subr_taskqueue.c src/sys/sys interrupt.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2009 15:15:17 -0000 jhb 2009-10-23 15:14:54 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c kern_ktrace.c subr_bus.c subr_taskqueue.c sys/sys interrupt.h Log: SVN rev 198411 on 2009-10-23 15:14:54Z by jhb - Fix several off-by-one errors when using MAXCOMLEN. The p_comm[] and td_name[] arrays are actually MAXCOMLEN + 1 in size and a few places that created shadow copies of these arrays were just using MAXCOMLEN. - Prefer using sizeof() of an array type to explicit constants for the array length in a few places. - Ensure that all of p_comm[] and td_name[] is always zero'd during execve() to guard against any possible information leaks. Previously trailing garbage in p_comm[] could be leaked to userland in ktrace record headers via td_name[]. Reviewed by: bde Revision Changes Path 1.340 +7 -13 src/sys/kern/kern_exec.c 1.131 +6 -1 src/sys/kern/kern_ktrace.c 1.234 +1 -1 src/sys/kern/subr_bus.c 1.52 +2 -2 src/sys/kern/subr_taskqueue.c 1.48 +3 -3 src/sys/sys/interrupt.h