From owner-svn-src-head@freebsd.org Tue Apr 25 23:51:29 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83863D50836; Tue, 25 Apr 2017 23:51:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2B51AF1; Tue, 25 Apr 2017 23:51:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 4931B5444; Tue, 25 Apr 2017 23:51:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id E58C17D79; Tue, 25 Apr 2017 23:51:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 5ZYHFJtNNw_a; Tue, 25 Apr 2017 23:51:23 +0000 (UTC) Subject: Re: svn commit: r317409 - head/contrib/tcpdump DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 6CEB37D74 To: Ngie Cooper References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> Cc: Benjamin Kaduk , John Baldwin , "Rodney W. Grimes" , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Tue, 25 Apr 2017 16:51:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 23:51:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb Content-Type: multipart/mixed; boundary="4q40ISJpAo5TKdibfNNkojVDsSetcAbhI"; protected-headers="v1" From: Bryan Drewery To: Ngie Cooper Cc: Benjamin Kaduk , John Baldwin , "Rodney W. Grimes" , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> In-Reply-To: --4q40ISJpAo5TKdibfNNkojVDsSetcAbhI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/25/2017 3:12 PM, Ngie Cooper wrote: > On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery w= rote: >=20 > ... >=20 >> It is definitely more useful to note which repository and what VCS >> system the revision/hash/version refers to. But there's nothing >> inherently wrong about using a git hash. Github !=3D git. It is merel= y an >> interface to git and is not required to use any of the git repositorie= s >> on it given another mirror or local checkout. If a project uses git a= s >> their official VCS then a git hash is the proper reference. >=20 > The only issues with using git hashes stems from forced pushes and > the fact that only hashes can be garbage collected, but if we're using > an upstream that does that, they are using git wrong (it should only > be done for non-development mainlines). Then again, at least the > history will have been somewhat correct, as cvs/svn history can be > rewritten :/... > Thanks, > -Ngie >=20 "Force push". This exact same thing can happen with SVN and CVS by a repository admin. Respectable projects that are using git officially won't rebase their main branches unless under severe circumstance. Same for SVN/CVS. SVN->GIT mirrors or CVS->GIT mirrors may be prone to that naturally though, but we should not be cherry-picking from that since it is not the source of truth for the project. --=20 Regards, Bryan Drewery --4q40ISJpAo5TKdibfNNkojVDsSetcAbhI-- --1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJY/+DtAAoJEDXXcbtuRpfPNsYIALSGtV8O8zXZyFU1X0uV7A/S q3WmBafTHo6ddamTWbOJwSBncyivznOofnS6BKXSER59hsjhxGF5JYUp1hz7xBr1 nvGbqqZVxyBzLlBfSWVNWzZoeg33EpFakamaQEOKxeLb8IEFd4wJ2QCfQfCMlVkH mmbLrKxgYIVp9bhsYvx8RLIxPg0GMdG+O5h//nHGfmfp7p2TU3bQZp7J5VaAo909 vuZcBYj3JLnZ9dp4CagouqFcqIq8zhJDyToTc8AVdrV8cAWgm4+50SZstZOoE5Y8 LTabiRYEjQ7AslgA2m0r5OnVLPbf9GIHBwiT/QTK7s3MzH1wvXjJxOfAQpDvoqc= =+jZh -----END PGP SIGNATURE----- --1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb--