From owner-freebsd-current@FreeBSD.ORG Sat Jan 3 18:01:22 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F291106564A for ; Sat, 3 Jan 2009 18:01:22 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout011.mac.com (asmtpout011.mac.com [17.148.16.86]) by mx1.freebsd.org (Postfix) with ESMTP id 691838FC0C for ; Sat, 3 Jan 2009 18:01:22 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from [192.168.1.96] (75-101-29-67.dsl.static.sonic.net [75.101.29.67]) by asmtp011.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0KCW00F1SQ272N60@asmtp011.mac.com> for freebsd-current@freebsd.org; Sat, 03 Jan 2009 10:01:20 -0800 (PST) Message-id: <8F22F980-0D4C-4074-8685-3FFAD4558362@mac.com> From: Marcel Moolenaar To: "M. Warner Losh" In-reply-to: <20090103.104220.513891918.imp@bsdimp.com> Date: Sat, 03 Jan 2009 10:01:19 -0800 References: <20090103033543.GB77475@dragon.NUXI.org> <20090102.231410.-2001109684.imp@bsdimp.com> <440945C2-252E-489A-902E-A499753A5EF8@mac.com> <20090103.104220.513891918.imp@bsdimp.com> X-Mailer: Apple Mail (2.930.3) Cc: bsam@ipt.ru, freebsd-current@freebsd.org, fbsdlist@src.cx Subject: Re: gjournal is not automounted any more X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jan 2009 18:01:22 -0000 On Jan 3, 2009, at 9:42 AM, M. Warner Losh wrote: > In message: <440945C2-252E-489A-902E-A499753A5EF8@mac.com> > Marcel Moolenaar writes: > : > : On Jan 2, 2009, at 10:14 PM, M. Warner Losh wrote: > : > : > In message: <20090103033543.GB77475@dragon.NUXI.org> > : > "David O'Brien" writes: > : > : On Fri, Jan 02, 2009 at 11:47:57AM -0700, M. Warner Losh wrote: > : > : > In message: <20090102091334.GA41230@dragon.NUXI.org> > : > : > "David O'Brien" writes: > : > : > : Before 'fsck' would read the lable for the FS type. That > has > : > changed and > : > : > : thus you cannot just 'fsck /dev/ad1s1d' anymore. So the FS > : > type in fstab > : > : > : must be accurate. > : > : > > : > : > Why did that change? I routinely have disks that aren't in my > : > : > /etc/fstab that I mount and this is a pain in the backside. > : > : > : > : Due to r186240 which: > : > : Make gpart the default partitioning class on all platforms. > : > : > : > : Seems GEOM_PART_BSD does not like labels that GEOM_BSD did. > : > > : > Then why the change? Shouldn't we make it like them for > : > compatibility? > : > : David's statement is incorrect. They like the same labels > : for all practical purposes. The problem at hand here is > : that fsck(8) & newfs(8) ask of GEOM_BSD what the partition > : type is. This means 2 things: > : 1. Any platform that doesn't use the BSD disklabel by > : default needs to have a proper /etc/fstab and is not > : behaving the same as i386. > : 2. Switching to GPT as the default partitioning scheme > : yields the same problem. > : > : As I said in an email to arch@, it's good to query the > : partition type to determine what to do when more specific > : information is missing (running fsck(8) vs fsck_ffs(8)). > : But it wasn't something that was there at the switchover > : point. > > But my problems are with a platform that has BSD labels, and not GPT > labels, with a proper BSD label on the device. You don't have GEOM_BSD to service the DIOCGDINFO ioctl(2) anymore. We need to change fsck(8) so that it doesn't work only on BSD disk labels, but instead obtains the partition type (if applicable) in a more generic way so that it also applies to other partitioning schemes. -- Marcel Moolenaar xcllnt@mac.com