From owner-freebsd-stable@FreeBSD.ORG Fri Sep 1 16:21:47 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB6F516A4DD; Fri, 1 Sep 2006 16:21:46 +0000 (UTC) (envelope-from V.Haisman@sh.cvut.cz) Received: from service2.sh.cvut.cz (service2.sh.cvut.cz [147.32.127.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id EAC7043D58; Fri, 1 Sep 2006 16:21:27 +0000 (GMT) (envelope-from V.Haisman@sh.cvut.cz) Received: from localhost (localhost [127.0.0.1]) by service2.sh.cvut.cz (Postfix) with ESMTP id 7A0081379D1; Fri, 1 Sep 2006 18:21:26 +0200 (CEST) Received: from service2.sh.cvut.cz ([127.0.0.1]) by localhost (service2.sh.cvut.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 27146-10; Fri, 1 Sep 2006 18:21:19 +0200 (CEST) Received: from logout.sh.cvut.cz (logout.sh.cvut.cz [147.32.127.203]) by service2.sh.cvut.cz (Postfix) with ESMTP id F05081379A1; Fri, 1 Sep 2006 18:21:18 +0200 (CEST) Received: from [192.168.1.2] (localhost [127.0.0.1]) by logout.sh.cvut.cz (Postfix) with ESMTP id 9EB6861C32; Fri, 1 Sep 2006 18:21:18 +0200 (CEST) Message-ID: <44F85DEA.2010206@sh.cvut.cz> Date: Fri, 01 Sep 2006 18:20:58 +0200 From: =?UTF-8?B?VsOhY2xhdiBIYWlzbWFu?= User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Robert Watson References: <44F67DC2.1060900@sh.cvut.cz> <20060901104141.J4921@fledge.watson.org> In-Reply-To: <20060901104141.J4921@fledge.watson.org> X-Enigmail-Version: 0.94.0.0 OpenPGP: id=733031B4 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUnMzWJm5S+0864pn5r blp/hnW2up7X7uqftbNRVUrW1LGBdGfHwJqPi3ScoYtBQzhDxGEwAAAAB3RJTUUH1QoQDDgyQtx8 HQAAAkNJREFUeJzFU0toU0EUPYu66CpGdCUUmoUJkpUDQUoNBVEUrBJsq1Ki2EIKIUZ8mydBhYi0 wVUXJVCLCrFN4DIEQdxIqdBIFsMkWD9YJClCRGKjJaviynjfe8RPogtXPcObuXPOPXd+PHj+Aeyo QNmobGLXVeANGM+GsP0B2yqHHNVoCD2LwLglVGZx7yXSlADR0uZu9C4Bpy3hUxPvH/cuUw6UoPCL h64I8KAJuMpwRU8uUMJy0OIpHVeXmulZoCc/t0LlTbJLEY1EudPRcnVjgAP5Osdl4K5HVP4+2bAI okaUA0Iq6Q59+Zy2eMWN6EpFTsa3+uD1+JKj4TPHuYTSMaLScLAaqk94YJqG4ds30hojOVgYoNJc NTztNU2TBYbhu9Aafnq08ORja37da1NwBrN/b7NVEc+b8yecuYkp08vNvLYneVZRaSH1vS0UnfHm OUPzWaZufHPmCWSdWrfeGVQQKmcsO4If8pAdXJ/xF4QQAeOVY1AQQcfirwkLUWeWVTgi6vaGt2xe BGzBEIMQorru8RxgPqY1V6uxYnwVBRZEI1ytCm3dE8mC2DgcbzCJGHdBEVDKuWDSwsrSGoqzJmNt 2jJpNueIH0qS8/0JrDKnVBdvOzIsdVr4zaX9dn9xcLLKdCtQGfutVacLE9Ja+yfbDvO4aMWrklfK /JYv15C8Kw9S10kup5Bys0N1bLdcn4HvTl/Xlh6Fpllwj5/XpH9BUXn/ym0Dvv7Rt2MywojpYiSi i7Hsscaa19zZ//y/hR+BT/ns80nmJAAAAABJRU5ErkJggg== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC5189C888E8823AA4263F06A" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at service2.sh.cvut.cz X-Spam-Status: No, hits=-2.5 tagged_above=-255.0 required=5.0 tests=ALL_TRUSTED, AWL X-Spam-Level: Cc: freebsd-stable@freebsd.org Subject: Re: malloc(M_WAITOK) of "g_bio", forcing M_NOWAIT with non-sleepable locks held: X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2006 16:21:47 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC5189C888E8823AA4263F06A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Robert Watson wrote, On 1.9.2006 11:46: >=20 > On Thu, 31 Aug 2006, V=C3=A1clav Haisman wrote: >=20 >> I found this in logs of 6.1 box that I admin this morning. The machine= >> keeps running after that. >=20 > Indeed, there does appear to be a problem in the TCP socket option code= > with respect to performing copyin/copyout while holding the inpcb lock.= =20 > This problem is not present in the IP layer socket option code.=20 > However, the code between HEAD and 6-STABLE here differs significantly,= > so fixing this will require different changes in the two branches.=20 > Could you file a problem report on this, and forward me the PR receipt?= =20 > I'm on travel in India currently, with mixed connectivity, so it may be= > a little bit before I can get to fixing the problem. >=20 > In principle, the risk here is a deadlock, but the fix is a little > complicated as if we release the lock there, the state of the TCP socke= t > can change, so when the code picks up from the copyin/copyout, it needs= > to validate that the operation is still valid on the socket (i.e., the > connection hasn't been reset during the system call -- perhaps while th= e > application is blocked waiting on disk i/o for a paged out page that > contains the socket option). This is very unlikely to trigger in > practice, the warning there is quite conservative, but needs to be > addressed properly. >=20 > Thanks for the report, >=20 > Robert N M Watson > Computer Laboratory > University of Cambridge Here is the PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D102752 -- Vaclav Haisman --------------enigC5189C888E8823AA4263F06A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQEVAwUBRPhd/kNOZDESBK8FAQIKtQf+JVl57cOxPsmlhjVU22tJCr/WloqCkCFK 9f4928WY+9Tgk3qRzZtg7WW/kdA6f/kUZt8AKUOFXNS1euj0JGIQKOfFOt21Wz/B mtpkCdupBdzmN5AVmSRzGwaMKPOwDeK8DVjz4jDcQR8uJweDvC5sOVyKlocS9UGk M6oSfzOxyXSg8Od7D1VX7CzCdsWqZtz5x+cE0rHvhAkoB1nL3ojbfpvBKqNtvc7d vgGu3T+DK/l2W6PD/5iQ9Kgj+Nu0CN2T1Z3oT9Q1sPU6snXsrMSfBlZw/n4MEW5J uxDAQwSCp64H+sp5TjdzutM7dNRxBq0vUfEzXLWacn7RBk8FHVepXQ== =sXi6 -----END PGP SIGNATURE----- --------------enigC5189C888E8823AA4263F06A--