From owner-freebsd-acpi@FreeBSD.ORG Mon Sep 8 22:34:04 2008 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31D66106568C for ; Mon, 8 Sep 2008 22:34:04 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73]) by mx1.freebsd.org (Postfix) with ESMTP id BB8938FC16 for ; Mon, 8 Sep 2008 22:34:03 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from [213.142.183.219] (helo=gahrtop.localhost) by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1KcpJ4-0004i6-2s; Tue, 09 Sep 2008 00:34:02 +0200 Message-ID: <48C5A852.4040909@FreeBSD.org> Date: Tue, 09 Sep 2008 00:33:54 +0200 From: Pietro Cerutti Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.16 (X11/20080807) MIME-Version: 1.0 To: Nate Lawson References: <48C14091.4060309@FreeBSD.org> <48C16810.2030003@root.org> <48C59C98.5020408@FreeBSD.org> <48C5A152.9020505@root.org> <48C5A3B6.2070807@FreeBSD.org> <48C5A7E0.3010308@root.org> In-Reply-To: <48C5A7E0.3010308@root.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=9571F78E; url=http://gahr.ch/pgp/ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org X-Source: X-Source-Args: X-Source-Dir: Cc: freebsd-acpi@FreeBSD.org Subject: Re: kern/124223: [acpi] [patch] acpi_battery.c -- Notify user-defined critical level via devd(8) X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 22:34:04 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Nate Lawson wrote: | Pietro Cerutti wrote: |> Nate Lawson wrote: |> | Pietro Cerutti wrote: |> |> Nate Lawson wrote: |> |> | There are a few problems with your approach. |> |> | |> |> | Critical status is already reported with a flag when usermode polls |> for |> |> | the battery status: |> |> |> if (sc->bst.state & ACPI_BATT_STAT_CRITICAL) { |> |> |> if ((sc->flags & ACPI_BATT_STAT_CRITICAL) == 0) { |> |> |> sc->flags |= ACPI_BATT_STAT_CRITICAL; |> |> |> device_printf(dev, "critically low charge!\n"); |> |> |> } |> |> |> } |> |> |> |> I agree. Critical level is already checked for in the cmbat module. |> |> However, reporting is not done in a "standardized" way. My patch would |> |> just like to add notification through devd. |> | |> | But it doesn't just add notification through devd. It adds a thread, |> | that separately polls for battery state and sends a notify through devd. |> | If the user is running any battery app, there's a double poll for the |> | same info. |> | |> | I subscribe to the design approach that where it makes sense to do |> | something in usermode, don't do it in kernel mode. In this case, the IO |> | interface is poll-only, and any user app that is running can set its own |> | policy for how to deal with the information it gets from polling. |> |> [snip xbatt-related stuff] |> |> | Let's keep this in usermode, where policy belongs. |> |> That's fine. Thanks for reviewing that! | | Thanks for helping with FreeBSD. Hope you'll work on other stuff in the | future. Stay assured :) - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEAREKAAYFAkjFqFEACgkQwMJqmJVx946SqgCgrmDAjzwZcRURJmspEu5178xt 4aAAoNi+PRH6adhJf3QpllLGXwfPEDzD =y/OG -----END PGP SIGNATURE-----