From owner-cvs-all@FreeBSD.ORG Tue Aug 16 18:51:48 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A142016A426; Tue, 16 Aug 2005 18:51:48 +0000 (GMT) (envelope-from krion@voodoo.oberon.net) Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19B0743D48; Tue, 16 Aug 2005 18:51:48 +0000 (GMT) (envelope-from krion@voodoo.oberon.net) Received: from krion by voodoo.oberon.net with local (Exim 4.52 (FreeBSD)) id 1E56XG-000FTR-Oc; Tue, 16 Aug 2005 20:51:42 +0200 Date: Tue, 16 Aug 2005 20:51:42 +0200 From: Kirill Ponomarew To: Adam Weinberger Message-ID: <20050816185142.GB55949@voodoo.oberon.net> References: <200508160914.j7G9EiPd061656@repoman.freebsd.org> <4302300D.5040701@magnesium.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4302300D.5040701@magnesium.net> X-NCC-Regid: de.oberon X-NIC-HDL: KP869-RIPE Cc: cvs-ports@FreeBSD.org, Kirill Ponomarew , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/deskutils/gourmet Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 18:51:49 -0000 On Tue, Aug 16, 2005 at 02:27:25PM -0400, Adam Weinberger wrote: > Kirill Ponomarew wrote: > >krion 2005-08-16 09:14:43 UTC > > > > FreeBSD ports repository > > > > Modified files: > > deskutils/gourmet Makefile > > Log: > > Fix dependencies and build. > > > > Approved by: portmgr (implicit) > > This won't fix the build at all. Look at the pre-install: target. > gourmet requires a python-enabled metakit, and the only way to achieve > that is to have WITH_METAKIT_PYTHON=yes defined when building metakit. > All you've accomplished here is ensuring that the port is still BROKEN, > but in a different way. > > Your change may look better from the standpoint of pointyhat logs, but > in reality, gourmet's dependency is more logically on libmk4py.so than > on libmk4.so. I don't know how it would change the functionality of gourmet if metakit is built without python, but it would make sense to add NO_PACKAGE into Makefile to prevent cluster from building it until the problem is resolved. Feel free to add NO_PACKAGE/RESTRICTED if you know that package will be unusable for users. > The real issue lies within metakit. There is no python-enabled metakit > slave port, and one cannot choose to enable python based solely upon > whether python is already installed (you can only check for > ${PYTHON_CMD} after bsd.port.pre.mk, but you can only define WITH_PYTHON > *before* bsd.port.pre.mk... python could really use a WANT_PYTHON switch). > > I'd prefer to see this change backed out, but it doesn't make much > difference either way. In the future, though, could you please run > changes like this by me first? I recognize that you're doing your > portmgrial duties here, but surely one of my maintainer-based rights is > to challenge changes like this *before* they're committed. Yeah, you're right, sorry for that. -Kirill