From owner-freebsd-firewire@FreeBSD.ORG Fri Aug 29 18:16:29 2008 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C9A31065750 for ; Fri, 29 Aug 2008 18:16:29 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from plato.miralink.com (mail.miralink.com [70.103.185.20]) by mx1.freebsd.org (Postfix) with ESMTP id 4545A8FC16 for ; Fri, 29 Aug 2008 18:16:29 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by plato.miralink.com (Postfix) with ESMTP id D4F0B1A91B6; Fri, 29 Aug 2008 11:06:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -4.344 X-Spam-Level: X-Spam-Status: No, score=-4.344 tagged_above=-10 required=6.6 tests=[ALL_TRUSTED=-1.8, AWL=0.055, BAYES_00=-2.599] Received: from plato.miralink.com ([127.0.0.1]) by localhost (plato.miralink.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X5AjLRNOq3gg; Fri, 29 Aug 2008 11:06:43 -0700 (PDT) Received: from [10.0.0.40] (iago.office.miralink.com [10.0.0.40]) by plato.miralink.com (Postfix) with ESMTP id 6E9D51A91B5; Fri, 29 Aug 2008 11:06:43 -0700 (PDT) Message-ID: <48B83CFC.6030906@miralink.com> Date: Fri, 29 Aug 2008 11:16:28 -0700 From: Sean Bruno User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Dieter References: <200808290234.CAA18841@sopwith.solgatos.com> In-Reply-To: <200808290234.CAA18841@sopwith.solgatos.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-firewire@freebsd.org Subject: Re: This is where I'm going with fwcontrol X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 18:16:29 -0000 Dieter wrote: > More nit picking :-) > > Should > > >> Message ID Root ID R T Gap Count >> 00(2 bits) (5 bits) 1 1 (6 bits) >> > > be > > Message ID Root ID R T Gap Count > 00(2 bits) (6 bits) 1 1 (6 bits) > > send_phy_config() ANDs root_node with 0x3f, and the > "Physical ID" field in the controller register is > 6 bits. > Well, according to the 1394 documentation, no. The root ID is definitely 5 bits. The gap count is also 5 bits, I must have mis-counted. So, really it should be: Message ID Root ID R T Gap Count 00(2 bits) (5 bits) 1 1 (5 bits) This means that the Root ID and the Gap Count cannot exceed 0x3f(63). So, the masking of the values instead of generating and error seems wrong to me. I'm going to put in error checking to make sure the values comply with the specification and document the correct values in the man page and the comments of the code. -- Sean Bruno MiraLink Corporation 6015 NE 80th Ave, Ste 100 Portland, OR 97218 Phone 503-621-5143 Fax 503-621-5199 MSN: sbruno@miralink.com Google: seanwbruno@gmail.com Yahoo: sean_bruno@yahoo.com