From owner-freebsd-stable@FreeBSD.ORG  Fri Mar  5 07:35:15 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 40F18106564A;
	Fri,  5 Mar 2010 07:35:15 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84])
	by mx1.freebsd.org (Postfix) with ESMTP id DAF518FC18;
	Fri,  5 Mar 2010 07:35:14 +0000 (UTC)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by kabab.cs.huji.ac.il with esmtp
	id 1NnS3w-000BXW-HQ; Fri, 05 Mar 2010 09:35:08 +0200
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2
To: Rick Macklem <rmacklem@uoguelph.ca>
In-reply-to: <Pine.GSO.4.63.1003041910550.9956@muncher.cs.uoguelph.ca> 
References: <20100226174021.8feadad9.gerrit@pmp.uni-hannover.de> 
	<E1Nl6VA-000557-D9@kabab.cs.huji.ac.il>
	<20100226224320.8c4259bf.gerrit@pmp.uni-hannover.de>
	<4B884757.9040001@digiware.nl>
	<20100227080220.ac6a2e4d.gerrit@pmp.uni-hannover.de>
	<4B892918.4080701@digiware.nl>
	<20100227202105.f31cbef7.gerrit@pmp.uni-hannover.de>
	<20100227193819.GA60576@icarus.home.lan>
	<BD8AC9F6-DF96-41F9-8E92-48A4E5606DC7@anduin.net>
	<4B89943C.70704@digiware.nl>
	<20100227220310.GA65110@icarus.home.lan>
	<Pine.GSO.4.63.1003011703100.26054@muncher.cs.uoguelph.ca>
	<E1NmPHy-0009jy-Dj@kabab.cs.huji.ac.il>
	<Pine.GSO.4.63.1003041910550.9956@muncher.cs.uoguelph.ca>
Comments: In-reply-to Rick Macklem <rmacklem@uoguelph.ca>
	message dated "Thu, 04 Mar 2010 19:14:15 -0500."
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 05 Mar 2010 09:35:06 +0200
From: Daniel Braniss <danny@cs.huji.ac.il>
Message-ID: <E1NnS3w-000BXW-HQ@kabab.cs.huji.ac.il>
X-Mailman-Approved-At: Fri, 05 Mar 2010 12:34:28 +0000
Cc: stable@freebsd.org, freebsd-fs@freebsd.org,
	Willem Jan Withagen <wjw@digiware.nl>,
	=?utf-8?B?R2Vycml0IEvDvGhu?= <gerrit@pmp.uni-hannover.de>,
	=?utf-8?B?RWlyaWsgw5h2ZXJieQ==?= <ltning@anduin.net>,
	rwatson@freebsd.org, Jeremy Chadwick <freebsd@jdc.parodius.com>
Subject: Re: mbuf leakage with nfs/zfs? 
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2010 07:35:15 -0000

> 
> 
> On Tue, 2 Mar 2010, Daniel Braniss wrote:
> 
> >
> > just keep sending insights/pointers and enjoy life
> >
> 
> 
> You could try this patch for sys/rpc/replay.c. Completely untested and
> just typed into email (so don't give it to "patch", just edit the file).
> 
> - try adding these 2 lines just before the end of replay_setreply() in
>    sys/rpc/replay.c:
> 
> -	}
> +	} else if (m)
> +		m_freem(m);
>  	mtx_unlock(&rc->rc_lock);
> }
> 
> It's the only place I can see in replay.c that might leak, rick
> 
this is what I did:
--- a/sys/rpc/replay.c  Mon Mar 01 18:29:54 2010 +0200
+++ b/sys/rpc/replay.c  Fri Mar 05 09:24:17 2010 +0200
@@ -243,6 +243,9 @@
                rce->rce_repbody = m;
                if (m)
                        rc->rc_size += m_length(m, NULL);
+       } else if (m) {
+            printf("free m=%p ...\n", m);
+            m_freem(m);
        }
        mtx_unlock(&rc->rc_lock);
 }

but it didn't help, it's not triggered

Thanks for the explanation on the cache, things are begining to make sense.
If I understand, the reason for this cache is to prevent re-applying an
already performed rpc, which could lead to data corruption

btw, the list of CCs is rather big, so if anyone feels he rather be removed,
please let me know.

cheers,
	danny